Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: classification peer review and testing #103

Open
2 tasks done
ibevers opened this issue Jul 16, 2024 · 1 comment · May be fixed by #106
Open
2 tasks done

Task: classification peer review and testing #103

ibevers opened this issue Jul 16, 2024 · 1 comment · May be fixed by #106
Assignees
@ibevers

Comments

@ibevers
Copy link
Collaborator

ibevers commented Jul 16, 2024 •
edited
Loading

Description

Review and add tests

Tasks

  • review
  • add tests

Freeform Notes

No response
@ibevers ibevers self-assigned this Jul 16, 2024
@ibevers ibevers linked a pull request Jul 16, 2024 that will close this issue
Review and test classification #106
Open
@ibevers
Copy link
Collaborator Author

ibevers commented Jul 19, 2024

@wilke0818 It looks like you implemented this one originally. Everything looked good for the most part. There were a few misspelled words in the docstring and I updated your code to use the global fixture for audio. I also implemented batching, which you left as a to-do in the docstring. Let me know if you have any questions or feedback, and of course, feel free to change anything.🌱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibevers ibevers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Review and test classification sensein/senselab
1 participant
@ibevers