-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace C tests with Rust tests for the individual components and get rid of all C dependencies #37
Comments
sdroege
added a commit
that referenced
this issue
Feb 14, 2021
The implementation is proven to be equivalent to the C implementation now and faster in any meaningful way so simplify the build system and get rid of the C code. Next various unit tests have to be added for the removed comparison tests to ensure no regressions in the future. Fixes #37
sdroege
added a commit
that referenced
this issue
Feb 14, 2021
The implementation is proven to be equivalent to the C implementation now and faster in any meaningful way so simplify the build system and get rid of the C code. Next various unit tests have to be added for the removed comparison tests to ensure no regressions in the future. Fixes #37
sdroege
added a commit
that referenced
this issue
Feb 14, 2021
The implementation is proven to be equivalent to the C implementation now and faster in any meaningful way so simplify the build system and get rid of the C code. Next various unit tests have to be added for the removed comparison tests to ensure no regressions in the future. Fixes #37
sdroege
added a commit
that referenced
this issue
Feb 14, 2021
The implementation is proven to be equivalent to the C implementation now and faster in any meaningful way so simplify the build system and get rid of the C code. Next various unit tests have to be added for the removed comparison tests to ensure no regressions in the future. Fixes #37
sdroege
added a commit
that referenced
this issue
Feb 14, 2021
The implementation is proven to be equivalent to the C implementation now and faster in any meaningful way so simplify the build system and get rid of the C code. Next various unit tests have to be added for the removed comparison tests to ensure no regressions in the future. Fixes #37
sdroege
added a commit
that referenced
this issue
Feb 14, 2021
The implementation is proven to be equivalent to the C implementation now and faster in any meaningful way so simplify the build system and get rid of the C code. Next various unit tests have to be added for the removed comparison tests to ensure no regressions in the future. Fixes #37
sdroege
added a commit
that referenced
this issue
Feb 28, 2021
The implementation is proven to be equivalent to the C implementation now and faster in any meaningful way so simplify the build system and get rid of the C code. Next various unit tests have to be added for the removed comparison tests to ensure no regressions in the future. Fixes #37
sdroege
added a commit
that referenced
this issue
Feb 28, 2021
The implementation is proven to be equivalent to the C implementation now and faster in any meaningful way so simplify the build system and get rid of the C code. Next various unit tests have to be added for the removed comparison tests to ensure no regressions in the future. Fixes #37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From here:
I think at some point we should simply drop the C tests as long as we have new tests that cover all the components equally well. The implementation is diverging a lot from the C implementation already and at some point keeping the outputs similar enough with all the floating point inaccuracies depending on operation order/etc this is going to be annoying to maintain.
The text was updated successfully, but these errors were encountered: