Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply changes to the bash profile and zsh profile #2

Open
pjungermann opened this issue Apr 14, 2023 · 1 comment
Open

apply changes to the bash profile and zsh profile #2

pjungermann opened this issue Apr 14, 2023 · 1 comment

Comments

@pjungermann
Copy link

pjungermann commented Apr 14, 2023

Compared to https://get.sdkman.io/ the brew formula does not add anything to the bash or zsh profile. This only mentioned here at the README.md.

I didn't notice it even as hint / caveat when running

brew install sdkman-cli

I think, it would be great if no further manual action is necessary after running the install command.

@helpermethod
Copy link
Member

helpermethod commented Apr 16, 2023

The problem is that Homebrew discourages changing files outside of Homebrew (it is actually only possible by using some very ugly hacks).

So the best thing we could do is display a message after installation to add the necessary line(s) to Bash/zsh profile. Which btw is also discouraged, bc according to Homebrew this should the part of the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants