-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide a test environment with missing dependencies #10
Comments
Sounds fine, although I don't think it should be a blocker for scrapy/scrapy#3881. One thing to consider is the coverage report. Currently those mocks allow to reach every line in a single environment. With this approach I'll need to do a few adjustments to combine reports from different tox envs. I'm pasting this here so I don't forget: https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts |
@elacuesta I think if you use codecov they combine reports automatically, on their side. |
This should allow to drop some of the mock usages, and test it for real that the package works. I think a single environment without all the dependencies could work; it would only support dict items.
The text was updated successfully, but these errors were encountered: