Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent error calculation when reading TProfile #1148

Open
patinkaew opened this issue Feb 24, 2024 · 2 comments
Open

Inconsistent error calculation when reading TProfile #1148

patinkaew opened this issue Feb 24, 2024 · 2 comments
Labels
bug (unverified) The problem described would be a bug, but needs to be triaged

Comments

@patinkaew
Copy link

Dear Experts,

I'm getting different errors when trying to extract errors from TProfile saved in a root file. I tried two ways:

  1. pd_tp.errors(): this seems to get the correct error compared to error produced with ROOT (C++) script.
  2. np.sqrt(pd_tp.to_hist().variances()): this gives smaller errors which is incorrect.

Do you know what might be the issue here? It seems there are problems when converting to boost/hist.

I'm using uproot 4.7.3.

@patinkaew patinkaew added the bug (unverified) The problem described would be a bug, but needs to be triaged label Feb 24, 2024
@patinkaew
Copy link
Author

I just tried with uproot 5.2.2.

The problem with error calculation still persist. However, now if I do pd_tp.values() and pd_tp.to_hist().values(), I also got different values...

@jpivarski
Copy link
Member

Could it be related to #908 (comment) and #1000 (review)? I'm not 100% convinced that TProfile and a boost-histogram with WeightedMean Storage have the same data model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (unverified) The problem described would be a bug, but needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants