Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen elements reposition on load #355

Open
stefanv opened this issue Nov 1, 2023 · 1 comment
Open

Screen elements reposition on load #355

stefanv opened this issue Nov 1, 2023 · 1 comment
Assignees

Comments

@stefanv
Copy link
Member

stefanv commented Nov 1, 2023

See e.g. the button next to the title, which shifts on reload.

I think this is mainly because we don't define image widths. The fonts will still shift things around a bit, but let's pin down what we can.

This was also surfaced by the lighthouse report.

@alphapapa alphapapa added this to the 0.4 milestone Nov 1, 2023
@stefanv
Copy link
Member Author

stefanv commented Nov 2, 2023

Upon further investigation, it looks like the only (?) remaining shift is because of the font rendering. I investigated different ways of doing the font rendering: you can choose to hold off on display until the remote font arrives (bad), or not use the remote font if it fails to arrive before a certain time (probably bad), or the current behavior, which is to swap them out (causes shifts). No very good options, as far as I can tell.

See https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face/font-display

size-adjust is perhaps the most promising candidate, when it arrives.

@jarrodmillman jarrodmillman removed this from the 0.4 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants