Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify w/ pydata sphinx theme #225

Closed
3 tasks
jarrodmillman opened this issue Apr 24, 2023 · 4 comments
Closed
3 tasks

Unify w/ pydata sphinx theme #225

jarrodmillman opened this issue Apr 24, 2023 · 4 comments
Assignees

Comments

@jarrodmillman
Copy link
Member

jarrodmillman commented Apr 24, 2023

  • color schemes
  • variable names
  • config files
@alphapapa
Copy link
Contributor

As explained in our meeting the other day, we can more easily make changes in this project than in pydata-sphinx-theme, so we'll generally try to follow its example.

Doing this well will require some familiarity with both projects, so I'll treat this as a longer-term project and dig into it as I learn about them.

@alphapapa
Copy link
Contributor

alphapapa commented Oct 9, 2023

In our meeting now, here's the basic plan we've got:

  1. Add Sass to our build process.
  1. Add Makefile rule to take Sass from the pydata-sphinx-module repository, copy the files into our project, build them into CSS, and place them in the right place to be served as part of our theme.
  2. Begin editing our HTML/CSS to use the parts from the pydata-sphinx-theme (e.g. editing our CSS classes, using their variable names, etc).

@alphapapa
Copy link
Contributor

Ok, as a first step, I've pushed 03d2d9c which adds a rule to the Makefile to pull the SCSS files from the pydata-sphinx-theme repo and add imports for them to a single all.scss file. Next is to have that file built into a CSS file by Hugo and served with the site. I'll work on that tomorrow.

@jarrodmillman @brianhawthorne

@alphapapa alphapapa linked a pull request Oct 18, 2023 that will close this issue
@alphapapa
Copy link
Contributor

Closing in favor of new meta-issue: #302

@alphapapa alphapapa closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants