Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for black mirror in pre-commit check #254

Closed
WilliamJamieson opened this issue Aug 9, 2023 · 1 comment · Fixed by #255
Closed

Allow for black mirror in pre-commit check #254

WilliamJamieson opened this issue Aug 9, 2023 · 1 comment · Fixed by #255

Comments

@WilliamJamieson
Copy link
Contributor

Note that the latest black docs now recommends that users use https://github.com/psf/black-pre-commit-mirror instead of https://github.com/psf/black because the version of black provided by the mirror is faster.

The mirror supports all black tags from 22.3.0 to through to the current 23.7.0 tag. Hence, I think the guide should start recommending using this version of the black repo, or at the very least the sp-repo-review tool should allow for the use of this URL.
@henryiii henryiii mentioned this issue Aug 10, 2023
Merged
@henryiii
Copy link
Collaborator

henryiii commented Aug 10, 2023 •
edited
Loading

Also made the following PRs:

@rkansal47 rkansal47 mentioned this issue Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use black mirror scientific-python/cookie
2 participants
@henryiii @WilliamJamieson