Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkflowBadge pending items #2

Open
5 tasks done
sballesteros opened this issue Aug 20, 2019 · 0 comments
Open
5 tasks done

WorkflowBadge pending items #2

sballesteros opened this issue Aug 20, 2019 · 0 comments
Assignees

Comments

@sballesteros
Copy link
Member

sballesteros commented Aug 20, 2019

  • generalize badgeSize to width and height and handle x-overflow, in particular, allow width to be greater than height. width should be treated as a max width and we should allow the badge to overflow (in the x-axis) so users can scroll to the part overflowing.
  • use full dates (YYYY-MM-DD) as opposed to just MM-YYYY as some workflow are executed in less than a month or more than a year.
  • handle isPublicDuring and isPublicAfter property of the paths prop (see propTypes for definition). Main idea is to color code the full path background (as opposed to individual channels) to reflect the public visibility of the actions during and after the peer review process.
  • make the who can view identity of whom matrix a bit bigger in reader (see screenshot below). One option could be to increase a bit the height of the footer and to extend the width of the first column but only for the footer part. there may be room for a bit more legibility within the current space maybe with 1px spacing in between the cells? Screen Shot 2019-08-22 at 9 14 01 PM This screenshot can be reproduce with the latest story (e.g create-story -r --prod) and visiting /levinson2019a-demo?hostname=demo.sci.pe (no login required) or from nightly at: https://nightly.sci.pe/levinson2019a-demo?hostname=demo.sci.pe.
  • create the vertical dividers (white lines) base on the change of the id property in the paths prop as opposed to based on change of y property. That will allow to delimitate each actions (the change of role (y) seems to be already very clear with the path).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants