Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with icadefs.m being in ERPLAB #771

Open
jnvandermeer opened this issue May 13, 2024 · 4 comments
Open

Issue with icadefs.m being in ERPLAB #771

jnvandermeer opened this issue May 13, 2024 · 4 comments

Comments

@jnvandermeer
Copy link

jnvandermeer commented May 13, 2024

If you call binica from the gui,

then icadefs is called, which sets ICABINARY:

ICABINDARY = fullfile(eegpab_p, 'functions','supportfiles','ica_linux')

but then, binica.m is called (which then calls the ICABINARY), but there, it is written:

line 115:
icadefs
(this sets ICABINARY to the full path of where-to-find ica_linux executable).
line 117:
ICABINDARY = fullfile(eegpab_p, 'functions','supportfiles',ICABINARY)
(this messes up the full path of where to find ica_linux, by adding yet again the full path of eeglab, etc)

... which effectively makes ICABINARY unfindable.

If I change binica.m, on line 117, and replace ICABINARY with 'ica_linux', it works again.

I think this is a bug in eeglab, and may only be with linux, and not (very) often noticed because everybody just uses runica.m

@arnodelorme
Copy link
Collaborator

I think this issue has been fixed because icadefs.m no longer has the code setting the full path

ICABINDARY = fullfile(eegpab_p, 'functions','supportfiles','ica_linux')

@jnvandermeer
Copy link
Author

Hi Arnoud, you are right!

It was ERPLAB10.04, the eeglab plugin, that also contained and icadefs.m file. Because I added this plugin, the icadefs of ERPLAB was used, which lives in plugins/ERPLAB10.04/studio_functions/Functions/EEGLAB/Scalp/icadefs.m.

So, this probably better belonged to the ERPLAB repository.

@arnodelorme arnodelorme reopened this May 13, 2024
@arnodelorme
Copy link
Collaborator

Interesting point, one more reason to retire icadefs.m (which I was planning to do). I will implement a fix.

@arnodelorme arnodelorme changed the title bug in calling binica (on Linux) Issue with icadefs.m May 13, 2024
@arnodelorme
Copy link
Collaborator

@guanghuizhang0328 and @davidg622, how can we avoid the problem above?

@arnodelorme arnodelorme changed the title Issue with icadefs.m Issue with icadefs.m being in ERPLAB Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants