Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about server-side grpc-web support #181

Open
visortelle opened this issue Sep 6, 2022 · 5 comments
Open

Question about server-side grpc-web support #181

visortelle opened this issue Sep 6, 2022 · 5 comments

Comments

@visortelle
Copy link

Hello.

What about built-in server-side grpc-web support to eliminate additional proxies like Envoy?

Like it's done here:
https://docs.rs/tonic-web/latest/tonic_web/

Is there any chance that it may be done in the scope of the ScalaPB project or its better to wait for news on this topic from https://github.com/grpc/grpc-java ?

Thank you.

@steinybot
Copy link

One reason I want this is to greatly simplify my e2e tests. It would be nice to have a single test that could run on both platforms.

@thesamet
Copy link
Contributor

It would be nice if there was a Java implementation we could use. I'm not sure what it takes to write and maintain an implementation of a simple grpc-web server that is relatively simple (for tests only) though I am happy to accept a PR for that.

@steinybot
Copy link

Where do the shaded versions of io.grpc come from? I see them being added to grpcweb/target/scala-2.12/classes/io/grpc but how do they get there?

@thesamet
Copy link
Contributor

I don't believe there is any shading. But maybe you mean the fake ones created in this project? The sources are under grpcweb/src/main/scala/io/grpc/

@steinybot
Copy link

Thanks. For some reason I thought there was more to it than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants