Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton tab has too many scrollbars #8058

Open
hotzenklotz opened this issue Sep 5, 2024 · 3 comments · May be fixed by #8148
Open

Skeleton tab has too many scrollbars #8058

hotzenklotz opened this issue Sep 5, 2024 · 3 comments · May be fixed by #8148
Assignees

Comments

@hotzenklotz
Copy link
Member

Context

In the tracing UI > skeleton tab: Long tree lists and trees with long names can cause the layouting to slightly break. As a consequence there will be various scrollbars. See screenshot:

image

Durch die Scrollbar links-rechts unten im Skeleton Tab kommt man nicht mehr gut an den letzten Tree. Ich konnte das nicht mehr reproduzieren, aber ein Kollege auf dem Mac hat das Problem. Vielleicht ein Bug, weil zwei Scrollbars angezeigt werden? Bild im Anhang

Likely, a regression of #5872. Both the antd <Tree> component and the surrounding FlexLayout container have some constraints on this layouting.

Expected Behavior

There should only be one vertical scrollbar. (and maybe one horizontal one?)

Current Behavior

There are two horizontal scrollbars. The last tree item in the list is often blocked by the scrollbars.

Your Environment for bug

  • Version of WEBKNOSSOS (Release or Commit): 24.08.0
@dieknolle3333
Copy link
Contributor

Its caused by the button bar that starts with the search. Is it okay if I put the buttons into a flexbox, so that they are moved into a new line in case the tab gets narrow? Looks about like this
image

@dieknolle3333
Copy link
Contributor

In terms of the horizontal scroll bar, I agree that this would be nice. But we use the height prop for the virtualization of the tree and unfortunately Antd says in its tree doc, "Config virtual scroll height. Will not support horizontal scroll when enable this" so I think its not possible for the tree list alone.
Nevertheless maybe I can insert a minimum width, and add a horizontal scrollbar in case the tab is narrower

@hotzenklotz
Copy link
Member Author

Its caused by the button bar that starts with the search. Is it okay if I put the buttons into a flexbox, so that they are moved into a new line in case the tab gets narrow? Looks about like this

Let's do this for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants