Impossible to set current column for selected rows to incremental values and to bulk save all sheets

[aborruso]

Small description

Hi, I want to open and bulk save all the html tables I have here. All the tables have the same name, then I need to rename them using g+i, and then save them in bulk g+CTRL+s.

When I run g+i I have NameError: name 'setitem' is not defined.

If I change the name of the tables, in the saved HTML files, when I run g+CTRL+s, I have AttributeError: 'str' object has no attribute 'name'

I start from

 vd https://lab24.ilsole24ore.com/ecosistema-urbano/indexT.php --save-filetype=csv

Expected result

• to have the tables renamed;
• to be able to save the tables in multiple CSV files:

Actual result with screenshot

Steps to reproduce with sample data and a .vd
Please attach the commandlog (saved with Ctrl-D) to show the steps that led to the issue.
See here for more details.

sheet   col     row     longname        input   keystrokes      comment
global          null_value      set-option
global          save_filetype   set-option      csv
                        open-file       https://lab24.ilsole24ore.com/ecosistema-urbano/indexT.php      o
indexT                  select-rows             gs      select all rows
indexT  name            setcol-incr             gi      set current column for selected rows to incremental values

Additional context
Please include the version of VisiData: the latest dev saul.pw/VisiData v2.9dev

[frosencrantz]

@aborruso This simple task uncovers multiple bugs in the code. Thanks for the report! Thank you @anjakefala for fixing them!

[aborruso]

@aborruso This simple task uncovers multiple bugs in the code. Thanks for the report! Thank you @anjakefala for fixing them!

I'm very happy to be useful in some way. Thank you very much @anjakefala

I can't wait for the PR to be approved and test it :)

[anjakefala]

I think I fixed all of the issues that were rolled up in here! The fixes are on the develop branch, and will be part of the next release. =)

[aborruso]

I think I fixed all of the issues that were rolled up in here! The fixes are on the develop branch, and will be part of the next release. =)

I have installed it running pip3 install --upgrade --no-warn-script-location git+https://github.com/saulpw/visidata.git@develop, but I have again NameError: name 'setitem' is not defined.

My vd file

sheet	col	row	longname	input	keystrokes	comment
global		null_value	set-option			
global		save_filetype	set-option	csv		
			open-file	https://lab24.ilsole24ore.com/ecosistema-urbano/indexT.php	o	
indexT			select-rows		gs	select all rows
indexT	name		setcol-incr		gi	set current column for selected rows to incremental values

Thank you @anjakefala

[anjakefala]

Sorry. =(

I am pretty sure this is again an issue where there is an older version of VisiData lying around that you need to find, and uninstall. I cannot reproduce. D=

[aborruso]

I am pretty sure this is again an issue where there is an older version of VisiData lying around that you need to find, and uninstall. I cannot reproduce. D=

I have uninstalled and than installed it again: now it works.

Thank you again

[frosencrantz]

@anjakefala thanks for your fixes!

Later I realized my comment above (#1339 (comment) ) about this being a simple task is a good reason for simple tests for these fixes. So that future refactors don't break this code. This didn't really come to me until after the fixes were committed.

It looks like this issue points out a problem with the Visidata tests, not all commands are tested. Bad references can exist in commands without notice. I wonder if it would be useful to use something like pyp (hauntsaninja/pyp#26) to find missing references as part of testing, so there would be a check for this basic class of problem. I think if tests reported this error, it might have helped prevent one of the issues. Maybe a job for the someday list.

+@saulpw

[saulpw]

We have https://github.com/saulpw/visidata/blob/stable/visidata/tests/test_commands.py, but they aren't working properly. We should fix this and catch a lot of trivial bugs. Thanks for the reminder, @frosencrantz.