-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't depend on the entire Fabric API all at once #9
Comments
That's totally doable, but I can't see how an end user would benefit from that :P. I'll keep it in mind though. IRL stuff is getting in the way atm :P. |
Server admins will - for example, I'd have no need, as a vanilla-like server, to sync registries with or announce custom networking packets to Fabric clients, if there are no mods installed that would utilize that functionality. It's more a peace of mind thing than an actual practical performance degradation, even with 40+ API modules. |
I've made a suggestion on the template repository that goes into more detail on this: FabricMC/fabric-example-mod#175 |
I've tried getting this to work, but it crashes when starting to load server on modules that shouldn't even be loaded (e.g. |
It seems that it was due to config2brigadier lib; however, I'll wait to see how the mentioned issue plays out |
ah, another mod depending on the entirety of |
Thanks! |
IceJar depends on a very minimal subset of Fabric API, so it's not fair to declare a dependency on the entire
fabric
mod. AFAIK these are all of the imports IceJar uses from Fabric API (found via GitHub search):so:
Fabric API itself has like 40 other modules, so it would be nice not to force their inclusion.
This is likely something to be fixed on release rather than in development, but it's still worth tracking as an issue imho.
The text was updated successfully, but these errors were encountered: