Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .Net Core #18

Open
samjudson opened this issue Sep 27, 2016 · 19 comments
Open

Add support for .Net Core #18

samjudson opened this issue Sep 27, 2016 · 19 comments
Assignees

Comments

@samjudson
Copy link
Owner

Should be easy?

@samjudson samjudson self-assigned this Sep 27, 2016
@OgreBearing
Copy link

I would also like to see this support. The biggest hurdle that I could see would be if you are using other dependencies tht don't yet support .NET core

@technicaldogsbody
Copy link

+1

2 similar comments
@ValeraT1982
Copy link

+1

@itsff
Copy link

itsff commented Feb 8, 2017

+1

@ValeraT1982
Copy link

I tried to do it on my own. My solution works for operations that I need (OAuthGetAccessToken, AuthOAuthCheckToken, PeopleGetGroups, PhotosetsGetList, GalleriesGetList, TagsGetListUser, UploadPicture, PhotosLicensesSetLicense, GalleriesAddPhoto, PhotosetsAddPhoto, GroupsPoolsAdd).
Rewriting of 2-3 functions to use HttpClient instead of WebClient was the most difficult part.

Feel free to ask me if somebody needs any help with this.

@samjudson
Copy link
Owner Author

Any chance you could share your code. I'm most interested in the security stuff (the signature generation etc) as I don't know if this is the same in .Net core as in other versions of the framework.

@ValeraT1982
Copy link

I can send copy of the project by mail or give you access to my project on Bitbucket.
It looks like that security stuff is the same in Core, because I do not remember any changes connected with security or signatures.

@andrew-brainerd
Copy link

Any update/progress on this? I'd love to have the .NET Core support as well.

@kyleward
Copy link

kyleward commented Jul 1, 2017

+1

@samjudson
Copy link
Owner Author

Just to say I have checked a version that works on .Net Core (.net standard 1.3 library) so if someone could give it a go and let me know if there are any issues perhaps?

@mfeingol
Copy link

@samjudson: I just dropped by because I was looking for a version of this library that was compatible with .NET Standard. Any chance you can push your bits as a pre-release to NuGet and I'll give it a try?

@stuartshay
Copy link

@samjudson I just did some basic testing using the .NET Code and the so far looks good !!!
I pushed the working code to myget, will remove once you push to Nuget

Thanks Again for your work !!!

https://www.myget.org/feed/navigator/package/nuget/FlickrNetCore

@luk355
Copy link

luk355 commented Mar 20, 2018

Hey folks! Added support for .Net Core would be awesome... Is any of you, guys, @stuartshay, @ValeraT1982, planning to send the pull request with the required changes? Thanks a lot!

@stuartshay
Copy link

I did not make any changes, just published the existing code to myget, so no pull request required.

I would be willing to test the code further if a official package was published

@mfeingol
Copy link

mfeingol commented Aug 3, 2019

@samjudson: just curious as to whether you plan to publish an "official" package for .NET Standard.

Thanks.

@samjudson
Copy link
Owner Author

Hi Guys. Feel a bit bad about this but I've been quite busy at work etc (plus random other excuses). I also don't use Flickr much myself these days.

Anyway, v4 branch is actually newer code than the master branch, and is intended to replace the current master at some point. Since .Net Standard 2.0 came out it will probably be quite easy to get it up and running, although I had hoped to support a lower version of .Net Standard (e.g. 1.3) so I could support as many people as possible.

@travisterrell
Copy link

@samjudson Thanks for the update! In the end, I actually ended up using the code from the v4 branch, and it worked fine without any modifications. (Though I did extend one of the classes to add some functionality.)

The only thing that took me a while was realizing that another branch actually had Core implemented!

It'd be cool if you could find some time to get it merged into master (though I'm sure some of the merge conflicts will be a monster, especially since you haven't worked on it in a while.) Thanks again for your work!

@mfeingol
Copy link

I will just say that it would be awesome to get an update to this library with .NET Standard support.

@mfeingol
Copy link

mfeingol commented Aug 9, 2022

@samjudson: any chance of any activity on this?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests