From cc1f71bc94790fed6019167e9c9117ac0dc51ba6 Mon Sep 17 00:00:00 2001
From: Anunay Aatipamula <anunayaatipamul.dml21@iiitb.net>
Date: Wed, 10 Jul 2024 13:22:43 +0530
Subject: [PATCH 1/4] Update combobox.jsx

---
 components/combobox/combobox.jsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/components/combobox/combobox.jsx b/components/combobox/combobox.jsx
index d31acb95b..898968ad4 100644
--- a/components/combobox/combobox.jsx
+++ b/components/combobox/combobox.jsx
@@ -1774,7 +1774,8 @@ class Combobox extends React.Component {
 								}
 							}}
 							placeholder={labels.placeholderReadOnly}
-							readOnly
+							// based on WCAG Success Criteria: 4.1.2: Name, Role, Value - input element is interactive
+							//readOnly
 							required={props.required}
 							role="textbox"
 							value={inputValue}

From 7743b74c0b88d65231614aa28f20e52fb3a0bf8e Mon Sep 17 00:00:00 2001
From: Anunay Aatipamula <anunayaatipamul.dml21@iiitb.net>
Date: Wed, 10 Jul 2024 14:08:22 +0530
Subject: [PATCH 2/4] Update combobox.jsx

---
 components/combobox/combobox.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/combobox/combobox.jsx b/components/combobox/combobox.jsx
index 898968ad4..432b769c8 100644
--- a/components/combobox/combobox.jsx
+++ b/components/combobox/combobox.jsx
@@ -1775,7 +1775,7 @@ class Combobox extends React.Component {
 							}}
 							placeholder={labels.placeholderReadOnly}
 							// based on WCAG Success Criteria: 4.1.2: Name, Role, Value - input element is interactive
-							//readOnly
+							// readOnly
 							required={props.required}
 							role="textbox"
 							value={inputValue}

From bb64d743f705de6e862ce4e12c19a18c6f7fc1ad Mon Sep 17 00:00:00 2001
From: "anunay.aatipamula" <anunay.aatipamula@salesforce.com>
Date: Wed, 10 Jul 2024 14:52:22 +0530
Subject: [PATCH 3/4] Update snapshot

---
 .../__snapshots__/storybook-stories.storyshot | 12 --------
 .../datepicker.dom-snapshot-test.jsx.snap     |  7 +----
 .../__snapshots__/storybook-stories.storyshot | 28 -------------------
 3 files changed, 1 insertion(+), 46 deletions(-)

diff --git a/components/combobox/__docs__/__snapshots__/storybook-stories.storyshot b/components/combobox/__docs__/__snapshots__/storybook-stories.storyshot
index 36c8395cb..a75e4a5c1 100644
--- a/components/combobox/__docs__/__snapshots__/storybook-stories.storyshot
+++ b/components/combobox/__docs__/__snapshots__/storybook-stories.storyshot
@@ -3473,7 +3473,6 @@ exports[`DOM snapshots SLDSCombobox Inline Single Entity Selection 1`] = `
                       onFocus={[Function]}
                       onKeyDown={[Function]}
                       placeholder="Select an Option"
-                      readOnly={true}
                       required={false}
                       role="textbox"
                       type="text"
@@ -4682,7 +4681,6 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Menu Item Disabled 1`] = `
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select an Option"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
@@ -4774,7 +4772,6 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Selection - Right to Left (R
                 onFocus={[Function]}
                 onKeyDown={[Function]}
                 placeholder="Select an Option"
-                readOnly={true}
                 required={false}
                 role="textbox"
                 type="text"
@@ -4843,7 +4840,6 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Selection 1`] = `
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select an Option"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
@@ -4911,7 +4907,6 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Selection Custom Menu Item 1
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select company"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
@@ -4979,7 +4974,6 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Selection Deselect 1`] = `
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select an Option"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
@@ -5047,7 +5041,6 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Selection Disabled 1`] = `
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select an Option"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
@@ -7928,7 +7921,6 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection 1`] = `
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select an Option"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
@@ -7997,7 +7989,6 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection Custom Me
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select company"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
@@ -8629,7 +8620,6 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection Disabled
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select an Option"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
@@ -8697,7 +8687,6 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection Selected
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select an Option"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
@@ -8766,7 +8755,6 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection Selected
               onFocus={[Function]}
               onKeyDown={[Function]}
               placeholder="Select an Option"
-              readOnly={true}
               required={false}
               role="textbox"
               type="text"
diff --git a/components/date-picker/__tests__/__snapshots__/datepicker.dom-snapshot-test.jsx.snap b/components/date-picker/__tests__/__snapshots__/datepicker.dom-snapshot-test.jsx.snap
index c2b3ec148..5f4bd87ec 100644
--- a/components/date-picker/__tests__/__snapshots__/datepicker.dom-snapshot-test.jsx.snap
+++ b/components/date-picker/__tests__/__snapshots__/datepicker.dom-snapshot-test.jsx.snap
@@ -192,7 +192,6 @@ exports[`Datepicker
                       onFocus={[Function]}
                       onKeyDown={[Function]}
                       placeholder="Select an Option"
-                      readOnly={true}
                       required={false}
                       role="textbox"
                       type="text"
@@ -1056,7 +1055,6 @@ exports[`Datepicker
                         onFocus={[Function]}
                         onKeyDown={[Function]}
                         placeholder="Select an Option"
-                        readOnly={true}
                         required={false}
                         role="textbox"
                         type="text"
@@ -1919,7 +1917,6 @@ exports[`Datepicker
                       onFocus={[Function]}
                       onKeyDown={[Function]}
                       placeholder="Select an Option"
-                      readOnly={true}
                       required={false}
                       role="textbox"
                       type="text"
@@ -2779,7 +2776,6 @@ exports[`Datepicker Default DOM Snapshot 1`] = `
                       onFocus={[Function]}
                       onKeyDown={[Function]}
                       placeholder="Select an Option"
-                      readOnly={true}
                       required={false}
                       role="textbox"
                       type="text"
@@ -3486,7 +3482,7 @@ exports[`Datepicker Default HTML Snapshot 1`] = `
             <div class=\\"slds-form-element__control\\">
               <div class=\\"slds-combobox_container\\">
                 <div class=\\"slds-combobox slds-dropdown-trigger slds-dropdown-trigger_click ignore-react-onclickoutside slds-shrink-none\\" role=\\"combobox\\" aria-expanded=\\"false\\" aria-haspopup=\\"listbox\\">
-                  <div class=\\"slds-combobox__form-element slds-input-has-icon slds-input-has-icon_right\\" role=\\"none\\"><input type=\\"text\\" autoComplete=\\"off\\" class=\\"slds-input slds-combobox__input\\" id=\\"sample-datepicker-year-picklist\\" placeholder=\\"Select an Option\\" readonly=\\"\\" role=\\"textbox\\" aria-autocomplete=\\"list\\" value=\\"2014\\" /><span class=\\"slds-icon_container slds-input__icon slds-input__icon_right\\"><svg aria-hidden=\\"true\\" class=\\"slds-icon slds-icon_x-small slds-icon-text-default\\">
+                  <div class=\\"slds-combobox__form-element slds-input-has-icon slds-input-has-icon_right\\" role=\\"none\\"><input type=\\"text\\" autoComplete=\\"off\\" class=\\"slds-input slds-combobox__input\\" id=\\"sample-datepicker-year-picklist\\" placeholder=\\"Select an Option\\" role=\\"textbox\\" aria-autocomplete=\\"list\\" value=\\"2014\\" /><span class=\\"slds-icon_container slds-input__icon slds-input__icon_right\\"><svg aria-hidden=\\"true\\" class=\\"slds-icon slds-icon_x-small slds-icon-text-default\\">
                         <use href=\\"/assets/icons/utility-sprite/svg/symbols.svg#down\\"></use>
                       </svg></span></div>
                 </div>
@@ -3745,7 +3741,6 @@ exports[`ErrorPicker 1`] = `
                       onFocus={[Function]}
                       onKeyDown={[Function]}
                       placeholder="Select an Option"
-                      readOnly={true}
                       required={false}
                       role="textbox"
                       type="text"
diff --git a/components/expression/__docs__/__snapshots__/storybook-stories.storyshot b/components/expression/__docs__/__snapshots__/storybook-stories.storyshot
index 93350852c..e37e42bfd 100644
--- a/components/expression/__docs__/__snapshots__/storybook-stories.storyshot
+++ b/components/expression/__docs__/__snapshots__/storybook-stories.storyshot
@@ -58,7 +58,6 @@ exports[`DOM snapshots SLDSExpression Initial State 1`] = `
                     onFocus={[Function]}
                     onKeyDown={[Function]}
                     placeholder="Select an Option"
-                    readOnly={true}
                     required={false}
                     role="textbox"
                     type="text"
@@ -144,7 +143,6 @@ exports[`DOM snapshots SLDSExpression Initial State 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -209,7 +207,6 @@ exports[`DOM snapshots SLDSExpression Initial State 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -403,7 +400,6 @@ exports[`DOM snapshots SLDSExpression w/ Custom Logic 1`] = `
                     onFocus={[Function]}
                     onKeyDown={[Function]}
                     placeholder="Select an Option"
-                    readOnly={true}
                     required={false}
                     role="textbox"
                     type="text"
@@ -510,7 +506,6 @@ exports[`DOM snapshots SLDSExpression w/ Custom Logic 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -575,7 +570,6 @@ exports[`DOM snapshots SLDSExpression w/ Custom Logic 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -728,7 +722,6 @@ exports[`DOM snapshots SLDSExpression w/ Custom Logic 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -793,7 +786,6 @@ exports[`DOM snapshots SLDSExpression w/ Custom Logic 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -983,7 +975,6 @@ exports[`DOM snapshots SLDSExpression w/ Formula Logic 1`] = `
                   onFocus={[Function]}
                   onKeyDown={[Function]}
                   placeholder="Select an Option"
-                  readOnly={true}
                   required={false}
                   role="textbox"
                   type="text"
@@ -1301,7 +1292,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                     onFocus={[Function]}
                     onKeyDown={[Function]}
                     placeholder="Select an Option"
-                    readOnly={true}
                     required={false}
                     role="textbox"
                     type="text"
@@ -1387,7 +1377,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -1452,7 +1441,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -1600,7 +1588,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                           onFocus={[Function]}
                           onKeyDown={[Function]}
                           placeholder="Select an Option"
-                          readOnly={true}
                           required={false}
                           role="textbox"
                           type="text"
@@ -1686,7 +1673,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                                   onFocus={[Function]}
                                   onKeyDown={[Function]}
                                   placeholder="Select an Option"
-                                  readOnly={true}
                                   required={false}
                                   role="textbox"
                                   type="text"
@@ -1751,7 +1737,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                                   onFocus={[Function]}
                                   onKeyDown={[Function]}
                                   placeholder="Select an Option"
-                                  readOnly={true}
                                   required={false}
                                   role="textbox"
                                   type="text"
@@ -1904,7 +1889,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                                   onFocus={[Function]}
                                   onKeyDown={[Function]}
                                   placeholder="Select an Option"
-                                  readOnly={true}
                                   required={false}
                                   role="textbox"
                                   type="text"
@@ -1969,7 +1953,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                                   onFocus={[Function]}
                                   onKeyDown={[Function]}
                                   placeholder="Select an Option"
-                                  readOnly={true}
                                   required={false}
                                   role="textbox"
                                   type="text"
@@ -2141,7 +2124,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                           onFocus={[Function]}
                           onKeyDown={[Function]}
                           placeholder="Select an Option"
-                          readOnly={true}
                           required={false}
                           role="textbox"
                           type="text"
@@ -2248,7 +2230,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                                   onFocus={[Function]}
                                   onKeyDown={[Function]}
                                   placeholder="Select an Option"
-                                  readOnly={true}
                                   required={false}
                                   role="textbox"
                                   type="text"
@@ -2313,7 +2294,6 @@ exports[`DOM snapshots SLDSExpression w/ Group 1`] = `
                                   onFocus={[Function]}
                                   onKeyDown={[Function]}
                                   placeholder="Select an Option"
-                                  readOnly={true}
                                   required={false}
                                   role="textbox"
                                   type="text"
@@ -2531,7 +2511,6 @@ exports[`DOM snapshots SLDSExpression w/ Multiple Conditions 1`] = `
                     onFocus={[Function]}
                     onKeyDown={[Function]}
                     placeholder="Select an Option"
-                    readOnly={true}
                     required={false}
                     role="textbox"
                     type="text"
@@ -2617,7 +2596,6 @@ exports[`DOM snapshots SLDSExpression w/ Multiple Conditions 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -2682,7 +2660,6 @@ exports[`DOM snapshots SLDSExpression w/ Multiple Conditions 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -2835,7 +2812,6 @@ exports[`DOM snapshots SLDSExpression w/ Multiple Conditions 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -2900,7 +2876,6 @@ exports[`DOM snapshots SLDSExpression w/ Multiple Conditions 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -3094,7 +3069,6 @@ exports[`DOM snapshots SLDSExpression w/ Resource Selected 1`] = `
                     onFocus={[Function]}
                     onKeyDown={[Function]}
                     placeholder="Select an Option"
-                    readOnly={true}
                     required={false}
                     role="textbox"
                     type="text"
@@ -3180,7 +3154,6 @@ exports[`DOM snapshots SLDSExpression w/ Resource Selected 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"
@@ -3245,7 +3218,6 @@ exports[`DOM snapshots SLDSExpression w/ Resource Selected 1`] = `
                             onFocus={[Function]}
                             onKeyDown={[Function]}
                             placeholder="Select an Option"
-                            readOnly={true}
                             required={false}
                             role="textbox"
                             type="text"

From eccf9c85e84f8ecf8ba08a58b5afeca3c3127253 Mon Sep 17 00:00:00 2001
From: Anunay Aatipamula <anunayaatipamul.dml21@iiitb.net>
Date: Sun, 14 Jul 2024 08:33:18 +0530
Subject: [PATCH 4/4] removed comments

---
 components/combobox/combobox.jsx | 2 --
 1 file changed, 2 deletions(-)

diff --git a/components/combobox/combobox.jsx b/components/combobox/combobox.jsx
index 432b769c8..fa4e2d618 100644
--- a/components/combobox/combobox.jsx
+++ b/components/combobox/combobox.jsx
@@ -1774,8 +1774,6 @@ class Combobox extends React.Component {
 								}
 							}}
 							placeholder={labels.placeholderReadOnly}
-							// based on WCAG Success Criteria: 4.1.2: Name, Role, Value - input element is interactive
-							// readOnly
 							required={props.required}
 							role="textbox"
 							value={inputValue}