From d3e294f87455ea6524709b51888fc636bfb1cdfd Mon Sep 17 00:00:00 2001 From: Gerson Noboa Date: Fri, 25 Aug 2023 08:41:09 +0300 Subject: [PATCH] Capitalize accessibility identifier for back button Before, the accessibility label was "back". Now it is "Back". This is done to make unification of strings easier, as I don't want to have both strings to say the same thing. Also, all other accessibility labels start with a capital letter. Done in tandem with the snapshot test fix[1]. MOB-2538 [1]: https://github.com/salemove/ios-widgets-snapshots/pull/37 --- GliaWidgets/L10n.swift | 4 ++-- GliaWidgets/Resources/en.lproj/Deprecated.strings | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/GliaWidgets/L10n.swift b/GliaWidgets/L10n.swift index 11b9bb0e3..ef2ec7cf3 100644 --- a/GliaWidgets/L10n.swift +++ b/GliaWidgets/L10n.swift @@ -544,8 +544,8 @@ public enum L10n { public enum BackButton { /// public static let hint = L10n.tr("Deprecated", "chat.accessibility.header.backButton.hint", fallback: "") - /// back - public static let label = L10n.tr("Deprecated", "chat.accessibility.header.backButton.label", fallback: "back") + /// Back + public static let label = L10n.tr("Deprecated", "chat.accessibility.header.backButton.label", fallback: "Back") } public enum CloseButton { /// diff --git a/GliaWidgets/Resources/en.lproj/Deprecated.strings b/GliaWidgets/Resources/en.lproj/Deprecated.strings index 4878308ce..0d39adda9 100644 --- a/GliaWidgets/Resources/en.lproj/Deprecated.strings +++ b/GliaWidgets/Resources/en.lproj/Deprecated.strings @@ -117,7 +117,7 @@ "chat.accessibility.message.choiceCard.buttonState.normal" = ""; "chat.accessibility.message.choiceCard.buttonState.selected" = "Selected"; "chat.accessibility.message.choiceCard.buttonState.disabled" = "Disabled"; -"chat.accessibility.header.backButton.label" = "back"; +"chat.accessibility.header.backButton.label" = "Back"; "chat.accessibility.header.backButton.hint" = ""; "chat.accessibility.header.endButton.label" = "End"; "chat.accessibility.header.closeButton.label" = "Close";