Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Making release script more modular #56

Open
ChrisJefferson opened this issue Feb 17, 2021 · 3 comments
Open

Making release script more modular #56

ChrisJefferson opened this issue Feb 17, 2021 · 3 comments

Comments

@ChrisJefferson
Copy link
Contributor

As previously discussed, I would like to use this infrastructure to release GAP (which is also distributed with SAGE).

As an initial step, I was thinking about making a directory 'sagemath', and moving files relating specifically to sage into that directory, then editing the Makefile to have a variable (which can be changed) which uses this variable as a base.

As a concrete suggestion, I'm thinking about changing:

PATCHES=patches
CYGWIN_EXTRAS=cygwin_extras
RESOURCES=resources
DOT_SAGE=dot_sage

To something like:

PROGBASE?=sagemath
PATCHES=$(PROGBASE)/patches
CYGWIN_EXTRAS=$(PROGBASE)/cygwin_extras
RESOURCES=$(PROGBASE)/resources
DOT_SAGE=$(PROGBASE)/dot_sage

Before I started doing that, I wanted to check if that was OK. The other option would be to just change to "PATCHES?=patches".

@embray
Copy link
Contributor

embray commented Feb 17, 2021

I was thinking something a bit more ambitious, though maybe more ambitious than I have time for...
A lot of this machinery can work in general for creating an InnoSetup installer for some software that relies on Cygwin. All the Sage-specific Makefile rules can be moved out to separate files. Likewise the .iss file can be modularized a bit (.iss scripts will tend to be fairly application-specific, but there are a lot of bits in SageMath.iss that solve generic problems related to packaging Cygwin).

@ChrisJefferson
Copy link
Contributor Author

I'm having a look. One practical question, is there a "known good" target I can run to get a sage release? 'develop' seems currently broken (not sure if the issue is known, thought I would start just getting a good installer).

I wanted to make some small cleanups/changes, but obviously don't want to break building sage while I'm doing it.

@embray
Copy link
Contributor

embray commented Feb 22, 2021

No idea why develop would be broken, but if you set SAGE_VERSION=9.2 it should work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants