Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with keyboard input after sis s remove_job_and_descendants SIGKILL #206

Open
Icemole opened this issue Oct 7, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Icemole
Copy link
Collaborator

Icemole commented Oct 7, 2024

When I do a sis s remove_job_and_descendants ... and I finish the execution early by pressing ^C (for instance, because I had mistaken the command sequence from the history), I end up with a weird state in the terminal in which I have to press a key multiple times in order for the key to appear once in the terminal.

When I get out early, some thread is still printing stuff (looking for job: ..., delete jobs? (y/N) and so on), and the issue only happens after the thread has "stopped" printing (so, when it gets to delete jobs? (y/N)), so I believe the thread could be consuming some of the input reserved for the main terminal (if that's a thing).

You could argue that I should exit properly when prompted for delete jobs?, but my instinct always tells me to leave early, so I have to train my instinct 😄 still, this doesn't remove the fact that there's something going on with the threading in sis s remove_jobs_and_descendants, since I haven't had the terminal state go wrong after any sis m.

Had this been already reported before?

@Icemole Icemole added the bug Something isn't working label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant