Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nn.pad should output new dim tag #223

Open
albertz opened this issue Oct 18, 2022 · 3 comments
Open

nn.pad should output new dim tag #223

albertz opened this issue Oct 18, 2022 · 3 comments
Assignees
Milestone

Comments

@albertz
Copy link
Member

albertz commented Oct 18, 2022

All functions which create a new dim tag output that new dim tag (for example nn.merge_dims or whatever). nn.pad is inconsistent in that it does not.

@albertz albertz added this to the first-release milestone Oct 18, 2022
@albertz
Copy link
Member Author

albertz commented Oct 19, 2022

@JackTemaki @Atticus1806 agree? This probably would break some existing setups.

@Atticus1806
Copy link
Contributor

It would break a network for me, but I would not mind since it needs to be updated next time I update returnn_common anyways and this is nothing that would go unnoticed. I think the changes which potentially can go unnoticed are the dangerous ones, things like this are fine for now.

@albertz
Copy link
Member Author

albertz commented Oct 19, 2022

Yea ok. Although, even if a change is dangerous, I think currently the priority would be on what is effectively the better API in the end, so this is also my main question here, what actually makes more sense.

(But anyway, I think the number of breaking changes up to first stable release is not much anymore, and after that, we would not do any breaking changes anymore anyway.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants