Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Our Ship 2 - current issues/unsynced features #167

Open
2 of 7 tasks
SokyranTheDragon opened this issue Feb 8, 2022 · 16 comments
Open
2 of 7 tasks

Save Our Ship 2 - current issues/unsynced features #167

SokyranTheDragon opened this issue Feb 8, 2022 · 16 comments
Labels
1.3 bug Something isn't working

Comments

@SokyranTheDragon
Copy link
Member

SokyranTheDragon commented Feb 8, 2022

  • Sending a ship into space is causing a desync (though starting the countdown is fine)
  • The background in space is broken (if there's no background at all - open a space map in singleplayer)
  • Moving ship around, landing, and similar options not synced - make the host do it and get the other players to rejoin
  • Some float menus (the ones that appear on right-click) might not be synced - please report which ones aren't if you find any
  • Some potential issues with shuttles - (un)drafting may not always synced, launching them may cause issues
  • Using the option to show report on the ship bridge could cause desyncs (especially if done in space, is it even possible?), looks like it might recalculate some stuff there
  • Changing allowed torpedo types doesn't work and causes error when attempted - as a workaround, forbid the torpedoes you don't want being used
@MacInnis117
Copy link

Weapons won't work while using multiplayer mod with "save our ship 2".
Removed the multiplayer mod and weapons and space ship work again.

@SokyranTheDragon
Copy link
Member Author

I can't seem to be able to reproduce this. Are you trying specific weapon types?

@MacInnis117
Copy link

All weapons won't fire. I tried firing them on there own and all together and nothing seems to work. I know how the mod works and tested it on single player as it was my first time using the mod and it worked fine on there but not when I would run a test using the mp mod.

@AuthenticSaltz
Copy link

For whatever reason, The top down view of the ship is just grey, I can see colonist names and can select things, however, I cant see anything other than colonist names because of said grey. Normal ground for an actual colony works fine, however, spaceships dont. I can elaborate further if needed, tested it for about half an hour. Cheers.

@notfood
Copy link
Member

notfood commented Mar 12, 2022

It's probably erroing, attach the partial log, only the relevant part.

@AuthenticSaltz
Copy link

How do I go about attaching a partial log? Never really gone out of my way to get help with/report bugs before, Sorry.

@EChinDev
Copy link

Hi, having the same error as AuthenticSaltz and I couldn't find any other resources concerning this issue. https://gist.github.com/723c0879064dc736b84bfa06a649ea33 Here's the uploaded log file. I'm also unfamiliar with partial log etiquette so let me know if you need the log in some other format.

From the testing I've done, it seems to just be between multiplayer and sos2, disabling all other mods didn't resolve the issue. Everything works fine in SP but as soon as a world is hosted in MP, I get that gray screen issue as previously described.

Let me know if there's any other information I can provide, thanks in advance.

@SweptWasTaken
Copy link
Member

SweptWasTaken commented Apr 2, 2022

I'm also getting the grey screen issue when on the ship.

Error log from my modpack with Rim73 loaded.
https://gist.github.com/35e3aa78636d291b4d8d86efd760982a

Clean error log with just MP, MP Compat, HugsLib, SOS2 loaded.
https://gist.github.com/9c6753598114990ad41b69e726138ad5

@mikaelax123
Copy link

I got exact same problem with same error as SweptWasTaken, EChinDev and AuthenticSaltz aswell. I just get a grey screen as soon as i hit host when in space/go in to space when hosted a multiplayer game. (gray screen only appears on the space map if i have colonists on the ground that map is fine still)

@asenright
Copy link

Same issue- as soon as I host the server when in orbit, I get a grey screen with 824 of this error:

Root level exception in Update(): System.NullReferenceException: Object reference not set to an instance of an object
  at Verse.MapDrawer.MapMeshDrawerUpdate_First () [0x0001b] in <99518a644a3e4a7ea3fde566568df84a>:0 
  at (wrapper dynamic-method) Verse.Map.Verse.Map.MapUpdate_Patch5(Verse.Map)
  at (wrapper dynamic-method) Verse.Game.Verse.Game.UpdatePlay_Patch2(Verse.Game)
  at Verse.Root_Play.Update () [0x00032] in <99518a644a3e4a7ea3fde566568df84a>:0 
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Error (string)
Verse.Root_Play:Update ()

So something in orbit isn't playing nicely with the MapDrawer?

@aschmitz13
Copy link

Is that being worked on. I am so much waiting for it

@SokyranTheDragon
Copy link
Member Author

Not at the moment. I've been busy with other stuff for the most part. I'm unsure when I'll get back to it.

@SokyranTheDragon
Copy link
Member Author

The patch will most likely need to be updated to support SoS2 for 1.4

https://github.com/SonicTHI/SaveOurShip2Experimental

SOS2 EXPERIMENTAL (SOS2EXP) is the maintained version of Save Our Ship 2 for RimWorld 1.4. It includes over a years worth of bugfixes, performance optimizations, mechanics changes and some new features that might need more testing.

@aschmitz13
Copy link

Any news if it's playable right now

@SokyranTheDragon
Copy link
Member Author

In 1.3, should most likely be. Not counting the stuff mentioned earlier.

In 1.4, no work whatsoever was done on it. Unless you manage to get the 1.3 version to run on 1.4 (I highly doubt that), it's not going to work.

@PSR2144-3933
Copy link

any news for sos2/ce compat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants