Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit debug test runners to drop --test-args clang filters on run-make tests #132034

Open
2 tasks
jieyouxu opened this issue Oct 22, 2024 · 0 comments
Open
2 tasks

Audit debug test runners to drop --test-args clang filters on run-make tests #132034

jieyouxu opened this issue Oct 22, 2024 · 0 comments
Assignees
@jieyouxu
Labels
A-run-make Area: port run-make Makefiles to rmake.rs C-bug Category: This is a bug. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Oct 22, 2024 •
edited
Loading

Context

Only two CI jobs have RUSTBUILD_FORCE_CLANG_BASED_TESTS 1 set, which is a necessary condition for //@ needs-force-clang-based-tests run-make tests to run. These tests (at the time when this issue was opened) pass a --test-args clang filter to the run-make test suite, meaning only run-make tests with clang in their name will run. This is a footgun which meant that several //@ needs-force-clang-based-tests run-make tests never ran in any CI jobs.

Known test runners:

Implementation history
@jieyouxu jieyouxu added A-run-make Area: port run-make Makefiles to rmake.rs T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 22, 2024
@jieyouxu jieyouxu self-assigned this Oct 22, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 22, 2024
@jieyouxu jieyouxu mentioned this issue Oct 22, 2024
Open
@jieyouxu jieyouxu added C-bug Category: This is a bug. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 22, 2024
@jieyouxu jieyouxu mentioned this issue Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs C-bug Category: This is a bug. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Oxidizing run-make tests
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot