Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: running crater locally #135

Closed
2 tasks done
aidanhs opened this issue Sep 18, 2017 · 6 comments
Closed
2 tasks done

Tracking issue: running crater locally #135

aidanhs opened this issue Sep 18, 2017 · 6 comments

Comments

@aidanhs
Copy link
Member

aidanhs commented Sep 18, 2017

We would like people interested in crater to be able to clone and run a series of commands to be able to get a quick taste of the full crater process.

Known papercuts/issues here include:

These are just the known issues so far.

@aidanhs
Copy link
Member Author

aidanhs commented Oct 16, 2017

rust-lang/rustup#618 (comment) - rustup issue that seems to make it impossible for crater to install its own rustup if you have a version installed in the default location.

Edit: I was wrong, just a bad error message from rustup

@aidanhs
Copy link
Member Author

aidanhs commented Oct 17, 2017

The README now suggests for people to use a 'mini' docker environment when testing locally, so I think this is done for now!

@alkis
Copy link

alkis commented Oct 18, 2017

I tried this on windows but crater binary fails to compile with:

   Compiling crater v0.1.0 (file:///C:/Users/alkis/Projects/crater)
error[E0433]: failed to resolve. Use of undeclared type or module `kernel32`
   --> src\run.rs:165:26
    |
165 |             let handle = kernel32::OpenProcess(winapi::winnt::PROCESS_TERMINATE, 0, id);
    |                          ^^^^^^^^ Use of undeclared type or module `kernel32`

error[E0433]: failed to resolve. Use of undeclared type or module `winapi`
   --> src\run.rs:165:48
    |
165 |             let handle = kernel32::OpenProcess(winapi::winnt::PROCESS_TERMINATE, 0, id);
    |                                                ^^^^^^ Use of undeclared type or module `winapi`

error[E0433]: failed to resolve. Use of undeclared type or module `kernel32`
   --> src\run.rs:166:13
    |
166 |             kernel32::TerminateProcess(handle, 101);
    |             ^^^^^^^^ Use of undeclared type or module `kernel32`

error[E0433]: failed to resolve. Use of undeclared type or module `kernel32`
   --> src\run.rs:167:16
    |
167 |             if kernel32::CloseHandle(handle) == 0 {
    |                ^^^^^^^^ Use of undeclared type or module `kernel32`

error: unused extern crate
  --> src\lib.rs:14:1
   |
14 | extern crate libc;
   | ^^^^^^^^^^^^^^^^^^
   |
note: lint level defined here
  --> src\lib.rs:1:9
   |
1  | #![deny(unused_extern_crates)]
   |         ^^^^^^^^^^^^^^^^^^^^

error: aborting due to 5 previous errors

error: Could not compile `crater`.

Is crater not expected to work on windows?

@aidanhs
Copy link
Member Author

aidanhs commented Oct 19, 2017

Unfortunately crater does not yet work on Windows. This is absolutely a problem and something we need to fix at some point, but we've just not had a chance to get to it yet!

@alkis
Copy link

alkis commented Oct 20, 2017

This is unfortunate. FWIW the README claims that it should work on windows :-)

In any case, do you have any idea how far away this is from working on windows? What is missing?

@retep998 retep998 mentioned this issue Oct 20, 2017
13 tasks
@aidanhs
Copy link
Member Author

aidanhs commented Oct 20, 2017

Yeah, the readme needs attention since I don't think that's ever been the case! I'll jot down some thoughts on #149 about Windows support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants