Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties set at fladle scope don't get propagated to individual configs #240

Open
valeraz opened this issue Mar 31, 2021 · 2 comments · Fixed by #243
Open

Properties set at fladle scope don't get propagated to individual configs #240

valeraz opened this issue Mar 31, 2021 · 2 comments · Fixed by #243

Comments

@valeraz
Copy link

valeraz commented Mar 31, 2021

When executing ./gradlew app:runFlankReleaseVariantTests from the configuration below, I noticed that orchestrator was still set to false (the default), despite the fact that it was set to true at the top-level scope:

fladle {
  useOrchestrator.set(true) // PROBLEM: not being propagated down
  configs {
    create("releaseVariantTests") {
      debugApk.set(project.provider { "$buildDir/outputs/apk/internal/release/$apkName" })
      instrumentationApk.set("$buildDir/outputs/apk/androidTest/internal/release/$testApkName")
      devices.set(listOf(mapOf("model" to "walleye" /* pixel2 */, "version" to "27"))) //
      testTargets.set(listOf("package slack.external"))
    }
  }
}

Running the fladle kotlin (sample)[https://github.com/runningcode/fladle/blob/master/sample-kotlin/build.gradle.kts] should repro this error.

@runningcode
Copy link
Owner

Thanks for the repro :D i should have noticed since its in this project. Will take a look!

@valeraz
Copy link
Author

valeraz commented Apr 9, 2021

useOrchestrator property still doesn't propagate as expected for me. All other ones seem to work as expected.

@runningcode runningcode reopened this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants