This repository has been archived by the owner on Oct 19, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Make inclusion of react-router (JS) optional #3
Labels
Milestone
Comments
Hyperloop.cancel_import in application.rb |
In application.rb or hyperloop.rb ? |
in app/javascripts/application.rb |
I guess it works in either place... in the initializer it would be My personal preference is in the initializer. More rails-ish. Just let the application.rb be a file that is never edited, and control config through the initializer or if working with JS files through the webpack stuff. |
should be documented, that when pulling in react or router or whatever js by node, webpacker whatever, hyperloop imports must be cancelled |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Comment from @barriehadfield:
The other gotcha I have gotten over is that Hyperlink Router includes its own source of React and this is a nightmare for me as I get into NPM version hell, so I use a fork with no source included and get React and ReactDOM via NPM
The text was updated successfully, but these errors were encountered: