Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full error stack and diagnostics are not printed #51

Open
tmplt opened this issue Oct 27, 2021 · 3 comments
Open

Full error stack and diagnostics are not printed #51

tmplt opened this issue Oct 27, 2021 · 3 comments
Labels
bug Something isn't working
Milestone
v0.4.0

Comments

@tmplt
Copy link
Member

tmplt commented Oct 27, 2021

In RTICScopeError::render the error must be printed via {:?}, but this breaks the layout style. Additionally, diagnostics for some errors (at least RecoveryError) are not propagated, and thus not printed.
@tmplt tmplt added the bug Something isn't working label Oct 27, 2021
@tmplt tmplt added this to the v0.3.0 milestone Oct 27, 2021
tmplt added a commit that referenced this issue Oct 27, 2021
@tmplt
render whole error message
9c9a80a 
This breaks the layout style, but at least we get more info on what
failed.

Related to #51.
@tmplt
Copy link
Member Author

tmplt commented Oct 27, 2021

Hints that are buried beneath any level of abstraction from RTICScopeError are not propagated (PACError works, for example). Some type info is lost somewhere.

tmplt added a commit that referenced this issue Oct 28, 2021
@tmplt
don't demote RecoveryErrors
374555d 
RecoveryError hints are not properly forwarded.

Related to #51.
@tmplt
Copy link
Member Author

tmplt commented Oct 28, 2021

Hints for hinted errors are now printed as expected. As long as we don't decorate relevant calls with a context it will stay that way.

Reverting to only printing top-level error, for now.

@tmplt tmplt modified the milestones: v0.3.0, mvp Oct 29, 2021
tmplt added a commit that referenced this issue Nov 18, 2021
@tmplt
pretty-print all errors instead of only top-level
b538978 
Related to #51. We should be able to iterate over the errors instead,
but this will do meanwhile.
@tmplt tmplt added this to the v0.4.0 milestone Nov 19, 2021
@tmplt
Copy link
Member Author

tmplt commented Nov 30, 2021

We can Chain over an error by using the std feature in anyhow. But if we do that on RTICScopeError we get a laundry list of traits we need to implement, all of which seem completely unrelated except for Iterator. Perhaps the other traits are derived upon Iterator and the compiler is just confused in this context?

@tmplt tmplt modified the milestones: v0.3.1, v0.3.2 Jan 13, 2022
@tmplt tmplt modified the milestones: v0.3.3, v0.4.0 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
1 participant
@tmplt