-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** #6
Comments
This package has strong dependence on at least one of |
Please also see https://r-spatial.org/r/2023/04/10/evolution3.html, fix best by June, latest October 2023. Removing retiring packages from DESCRIPTION, NAMESPACE and spurious roxygen tags, and running CMD check in a scenario using sp evolution status 2 (substitute use of rgdal with sf for projection/transformation/CRS) and absence of retiring packages from the library path gives this log: |
@bthieurmel See also https://r-spatial.org/r/2023/05/15/evolution4.html. Please take urgent steps to resolve this issue. No positive changes appear in the repository. Less than three months remain to retain this package on CRAN. |
We have prepared a Pull Request with the modifications to remove requested dependencies @ #10, it will be done in coming days and before October 2023 |
@vargastat Thanks for responding. Please let me know if you would like me to run an instrumented CMD check before you submit to CRAN. |
Yes, I'd will love to have an instrumented CMD check before submit to CRAN , should I requested through the ticket or this email is enough?
…________________________________
De : Roger Bivand ***@***.***>
Envoyé : mercredi 30 août 2023 11:12
À : rte-antares-rpackage/spMaps ***@***.***>
Cc : VARGAS Tatiana ***@***.***>; Mention ***@***.***>
Objet : Re: [rte-antares-rpackage/spMaps] Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** (Issue #6)
Vous ne recevez pas souvent de courriers de la part de ***@***.*** Découvrez pourquoi cela est important<https://aka.ms/LearnAboutSenderIdentification>
EXPÉDITEUR EXTERNE: Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe à moins qu’ils ne proviennent d’un expéditeur fiable, ou que vous ayez l'assurance que le contenu provient d'une source sûre.
@vargastat<https://github.com/vargastat> Thanks for responding. Please let me know if you would like me to run an instrumented CMD check before you submit to CRAN.
—
Reply to this email directly, view it on GitHub<#6 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7AMLTSXBNKBOZ2KI4WUR23XX37ZRANCNFSM6AAAAAATDOVB4I>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
"Ce message est destiné exclusivement aux personnes ou entités auxquelles il est adressé et peut contenir des informations privilégiées ou confidentielles. Si vous avez reçu ce document par erreur, merci de nous l'indiquer par retour, de ne pas le transmettre et de procéder à sa destruction.
This message is solely intended for the use of the individual or entity to which it is addressed and may contain information that is privileged or confidential. If you have received this communication by error, please notify us immediately by electronic mail, do not disclose it and delete the original message."
"Ce message est destiné exclusivement aux personnes ou entités auxquelles il est adressé et peut contenir des informations privilégiées ou confidentielles. Si vous avez reçu ce document par erreur, merci de nous l'indiquer par retour, de ne pas le transmettre et de procéder à sa destruction.
This message is solely intended for the use of the individual or entity to which it is addressed and may contain information that is privileged or confidential. If you have received this communication by error, please notify us immediately by electronic mail, do not disclose it and delete the original message."
|
Please let me know here when you are ready, and which branch I should check. |
Great !
I'm ready, please use branch below:
https://github.com/rte-antares-rpackage/spMaps/tree/fix/final_ANT-714
[https://opengraph.githubassets.com/eb907e67c689ca094c0f9ca373ea3176bae7615b736db57a27334e54529db1df/rte-antares-rpackage/spMaps]<https://github.com/rte-antares-rpackage/spMaps/tree/fix/final_ANT-714>
GitHub - rte-antares-rpackage/spMaps at fix/final_ANT-714<https://github.com/rte-antares-rpackage/spMaps/tree/fix/final_ANT-714>
Europe SpatialPolygonsDataFrame Builder. Contribute to rte-antares-rpackage/spMaps development by creating an account on GitHub.
github.com
…________________________________
De : Roger Bivand ***@***.***>
Envoyé : mercredi 30 août 2023 11:30
À : rte-antares-rpackage/spMaps ***@***.***>
Cc : VARGAS Tatiana ***@***.***>; Mention ***@***.***>
Objet : Re: [rte-antares-rpackage/spMaps] Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** (Issue #6)
Vous ne recevez pas souvent de courriers de la part de ***@***.*** Découvrez pourquoi cela est important<https://aka.ms/LearnAboutSenderIdentification>
EXPÉDITEUR EXTERNE: Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe à moins qu’ils ne proviennent d’un expéditeur fiable, ou que vous ayez l'assurance que le contenu provient d'une source sûre.
Please let me know here when you are ready, and which branch I should check.
—
Reply to this email directly, view it on GitHub<#6 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7AMLTVVLUJHD44AAIZNHN3XX4B37ANCNFSM6AAAAAATDOVB4I>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
"Ce message est destiné exclusivement aux personnes ou entités auxquelles il est adressé et peut contenir des informations privilégiées ou confidentielles. Si vous avez reçu ce document par erreur, merci de nous l'indiquer par retour, de ne pas le transmettre et de procéder à sa destruction.
This message is solely intended for the use of the individual or entity to which it is addressed and may contain information that is privileged or confidential. If you have received this communication by error, please notify us immediately by electronic mail, do not disclose it and delete the original message."
"Ce message est destiné exclusivement aux personnes ou entités auxquelles il est adressé et peut contenir des informations privilégiées ou confidentielles. Si vous avez reçu ce document par erreur, merci de nous l'indiquer par retour, de ne pas le transmettre et de procéder à sa destruction.
This message is solely intended for the use of the individual or entity to which it is addressed and may contain information that is privileged or confidential. If you have received this communication by error, please notify us immediately by electronic mail, do not disclose it and delete the original message."
|
Looks fine: |
@berthetclement Good, thanks. |
This package depends on (depends, imports or suggests) raster and one or more of the retiring packages rgdal, rgeos or maptools (https://r-spatial.org/r/2022/04/12/evolution.html, https://r-spatial.org/r/2022/12/14/evolution2.html). Since raster
3.6.3
, all use of external FOSS library functionality has been transferred to terra, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.The text was updated successfully, but these errors were encountered: