Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** #6

Closed
rsbivand opened this issue Dec 19, 2022 · 11 comments · Fixed by #10
Closed

Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** #6

rsbivand opened this issue Dec 19, 2022 · 11 comments · Fixed by #10

Comments

@rsbivand
Copy link

This package depends on (depends, imports or suggests) raster and one or more of the retiring packages rgdal, rgeos or maptools (https://r-spatial.org/r/2022/04/12/evolution.html, https://r-spatial.org/r/2022/12/14/evolution2.html). Since raster 3.6.3, all use of external FOSS library functionality has been transferred to terra, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.

@rsbivand
Copy link
Author

This package has strong dependence on at least one of rgdal, rgeos or maptools, but does not seem to use any functionality in code. The usage may have been in raster, which now uses terra instead, or may be in examples or vignettes. Please move all use of rgdal, rgeos or maptools to Suggests: and protect any use against these packages not being present. The packages will be archived in October 2023. See https://r-spatial.org/r/2022/12/14/evolution2.html and https://rsbivand.github.io/csds_jan23/bivand_csds_ssg_230117.pdf and perhaps view https://www.youtube.com/watch?v=TlpjIqTPMCA&list=PLzREt6r1NenmWEidssmLm-VO_YmAh4pq9&index=1.

@rsbivand
Copy link
Author

rsbivand commented May 1, 2023

Please also see https://r-spatial.org/r/2023/04/10/evolution3.html, fix best by June, latest October 2023.

Removing retiring packages from DESCRIPTION, NAMESPACE and spurious roxygen tags, and running CMD check in a scenario using sp evolution status 2 (substitute use of rgdal with sf for projection/transformation/CRS) and absence of retiring packages from the library path gives this log:
00check.log

@rsbivand
Copy link
Author

@bthieurmel See also https://r-spatial.org/r/2023/05/15/evolution4.html. Please take urgent steps to resolve this issue. No positive changes appear in the repository. Less than three months remain to retain this package on CRAN.

@vargastat
Copy link
Contributor

vargastat commented Aug 30, 2023

We have prepared a Pull Request with the modifications to remove requested dependencies @ #10, it will be done in coming days and before October 2023

@rsbivand
Copy link
Author

@vargastat Thanks for responding. Please let me know if you would like me to run an instrumented CMD check before you submit to CRAN.

@vargastat
Copy link
Contributor

vargastat commented Aug 30, 2023 via email

@rsbivand
Copy link
Author

Please let me know here when you are ready, and which branch I should check.

@vargastat
Copy link
Contributor

vargastat commented Aug 30, 2023 via email

@rsbivand
Copy link
Author

Looks fine:
00check.log
Only warning for package version, notes for absent suggested antaresViz, which also needs an urgent update: rte-antares-rpackage/antaresViz#200.

@berthetclement
Copy link
Collaborator

@rsbivand we are waiting cran check for 0.4.1 then we will launch new release (0.5.0) and fix old dependencies with PR #10 .
For antaresViz, we have PR waiting to fix old dependencies too.
Thank you for your warnings

@rsbivand
Copy link
Author

@berthetclement Good, thanks.

@berthetclement berthetclement linked a pull request Aug 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants