Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't show on WooCommerce login page #90

Open
dealifyhq opened this issue Aug 30, 2021 · 5 comments
Open

Doesn't show on WooCommerce login page #90

dealifyhq opened this issue Aug 30, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request priority/normal something that should be fixed sooner

Comments

@dealifyhq
Copy link

Hello,

First of all, thanks for building this great plugin! There is a slight issue, when selecting the option: Only show Google One-Tap on the log-in page, it will only show on the log-in page for admins (the wp-login), but not for WooCommerce users. For example, we have our login/registration URL at https://www.dealify.com/my/, but it won't show there, even though the option 'Enable One Tap Login Only on Login Screen' is on.

Could you check/fix where possible? Maybe it would be even better/more scalable to add an option to include pages/URLs where the one-tap should show (include/exclude URLs)?

Thanks again!

@ankitrox
Copy link
Contributor

Hi @dealifyhq,

There is an option to enable one-tap login Sitewide, can you please confirm if you've enabled that option in plugin settings?

@dealifyhq
Copy link
Author

dealifyhq commented Aug 30, 2021 via email

@ankitrox
Copy link
Contributor

You can try something like this:

  1. Enable one-tap login site-wide. This will add the one tap script and one tap related required markup as per this code.

  2. Add a custom code snippet in theme's functions.php file which will determine if the current page is not WooCommerce Login page, then remove these actions using remove_action. You can get OneTapLogin object to remove action using

use function RtCamp\GoogleLogin\plugin;



plugin()->container()->get( 'one_tap_login' );

Let me know if you need any further assistance.

@ankitrox ankitrox self-assigned this Aug 31, 2021
@ankitrox ankitrox added the priority/low lowest priority label Aug 31, 2021
@aviral-mittal
Copy link

@abhishekfdd As discussed, we will add a filter to make the one tap login button load on any user defined page. We will add this feature in the plugin.

@aviral-mittal aviral-mittal added enhancement New feature or request priority/normal something that should be fixed sooner and removed priority/low lowest priority labels Aug 2, 2022
@abhishekfdd
Copy link
Contributor

@aviral-mittal I checked and it will be better to use solution provided by Ankit in above comment instead of adding a new filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/normal something that should be fixed sooner
Projects
None yet
Development

No branches or pull requests

4 participants