[104] Fix deprecated filter warning #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/108/merge/ |
pdclark
suggested changes
Jun 21, 2022
| @@ -87,7 +87,7 @@ public static function filter_input( $type, $variable_name, $filter = FILTER_DEF | |||
| * Use the PHP method and bail out. | |||
| */ | |||
| switch ( $filter ) { | |||
| case FILTER_SANITIZE_STRING: | |||
| case FILTER_DEFAULT: | |||
There was a problem hiding this comment.
Blank filter_var filter or FILTER_DEFAULT, is equivalent to FILTER_UNSAFE_RAW. This will result in no filtering taking place by default. Filtering / sanitization should take place. Is there an issue with FILTER_SANITIZE_STRING in PHP 8.1?
There was a problem hiding this comment.
@pdclark FILTER_SANITIZE_STRING has been deprecated in PHP 8.1 and will result in E_WARNING
I think we may have to modify this function to use sanitize_text_field or other appropriate sanitization function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #104