Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility issue with PHP 8.1 #104

Open
Giovannss-ctrl opened this issue May 16, 2022 · 6 comments · May be fixed by #108
Open

Compatibility issue with PHP 8.1 #104

Giovannss-ctrl opened this issue May 16, 2022 · 6 comments · May be fixed by #108
Labels
compatibility issue Compatibility issue with any version of PHP, WP, etc on hold

Comments

@Giovannss-ctrl
Copy link

When I update the PHP version to 8.1, this error appears:

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /web/htdocs/www.mydomain.com/home/wp-content/plugins/login-with-google/src/Utils/Helper.php on line 90
@ankitrox ankitrox linked a pull request Jun 20, 2022 that will close this issue
Open
@aviral-mittal aviral-mittal added priority/high something that should be prioritised when taking up next issues bug Something isn't working priority/normal something that should be fixed sooner and removed priority/high something that should be prioritised when taking up next issues labels Jul 13, 2022
@aviral-mittal
Copy link

@abhishekfdd As discussed, even when fixing this issue for PHP8.1 , we will maintain back compatibility as well.

@aviral-mittal
Copy link

@abhishekfdd Do we have any updates for this?

@aviral-mittal
Copy link

@abhishekfdd As discussed, please drop an update with your findings so far here.

@aviral-mittal aviral-mittal added priority/low lowest priority compatibility issue Compatibility issue with any version of PHP, WP, etc and removed priority/normal something that should be fixed sooner bug Something isn't working labels Aug 2, 2022
@abhishekfdd
Copy link
Contributor

@aviral-mittal
FILTER_SANITIZE_STRING has been deprecated in PHP 8.1 and will result in warning.
We need to modify this function to use other appropriate sanitization function.

Since there are many references to this in our plugin it can be time consuming so let's keep this for future versions when we will provide full compatibility with PHP 8.1

@aviral-mittal aviral-mittal added on hold and removed priority/low lowest priority labels Aug 5, 2022
@kudlav
Copy link

kudlav commented Jun 8, 2023

Also discussed here:
https://wordpress.org/support/topic/compatibility-with-php-8-1-6/

This was referenced Jun 9, 2023
Closed
Merged
@jesperronn
Copy link

is this issue still relevant to keep open now that #158 is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility issue Compatibility issue with any version of PHP, WP, etc on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[104] Fix deprecated filter warning rtCamp/login-with-google
5 participants
@jesperronn @abhishekfdd @kudlav @aviral-mittal @Giovannss-ctrl