This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
test: block_exchange::long_get_block is ignored #450
Labels
bug
Something isn't working
Comments
I was hoping for #454 to magically fix this but alas, no change. |
bors bot
added a commit
that referenced
this issue
Jan 27, 2021
453: Fix multinode test spans r=koivunej a=koivunej This PR changes how the spans are set up from IpfsOptions and in UninitializedIpfs. While debugging the now ignored test (see #450) I found that the spans were configured wrong and thus none of the multiple nodes created by `spawn_nodes` could be differentiated. This also renames the spans to more logical from the "$root" given at `IpfsOptions::span`: `Span::current` => `$root:init` `Span::current` => `$root:init:swarm` `$root:swarm` => `$root:exec` (literally the executor libp2p spawns futures through) `$root` => `$root:bg_task` => `$root:swarm` (background task) `$root` => `$root:facade` (futures created through Ipfs::* methods) Still very far from perfect, but perhaps a step into better direction. Co-authored-by: Joonas Koivunen <[email protected]>
This might be simply that libp2p-kad no longer goes to work before a single peer has been |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See original comment. Should at minimum understand why it no longer works.
The text was updated successfully, but these errors were encountered: