Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degenerate triangle show up on some devices #5

Open
rreusser opened this issue Nov 19, 2021 · 1 comment
Open

Degenerate triangle show up on some devices #5

rreusser opened this issue Nov 19, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@rreusser
Copy link
Owner

rreusser commented Nov 19, 2021

In version 1.0.0, iOS 15 Safari shows some overlapping pixels where caps meet segments. I'm not sure what's causing this, unless maybe triangle strips require knowledge that it's a triangle strip in order to avoid? I thought as long as the tris met floating-point-correctly that the GPU had some magic way to get this right.

At any rate it's not a blocker and there are bigger self-intersection issues with transparent lines anyway, but it'd be nice to understand.

346edbe281ea15d0dda9eebd9e4658591282bdb192576e0825513c3dd6f9a101

@rreusser rreusser added the bug Something isn't working label Nov 19, 2021
@rreusser rreusser changed the title Stray overlapping pixels on mobile. Caps overlaps segments on mobile Nov 19, 2021
@rreusser
Copy link
Owner Author

rreusser commented Nov 19, 2021

Ah, the existence of these on the no-caps test suggests it's a result of degenerate triangles still resulting in a couple rasterized pixels. I think they should be degenerate to within floating point accuracy, so maybe this is just the way it works. https://rreusser.github.io/regl-gpu-lines/docs/tests.html#miter/insert-caps/none

Only seems to happen for endpoint caps. Full opacity or depth testing are not subject to the problem. Backface culling cuts it in half.

@rreusser rreusser changed the title Caps overlaps segments on mobile Degenerate triangle show up on some devices Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant