-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly check eligibility when someone signs up for a crew #59
Labels
Comments
MasterOdin
added
BUG
Priority 2
These are normal bugs that don't break site functionality, but don't necessarily work well.
labels
Sep 10, 2018
MasterOdin
changed the title
Probably check eligibility when someone signs up for a crew
Properly check eligibility when someone signs up for a crew
Sep 10, 2018
lramos15
added
Priority 1
This is something we want fixed first and foremost.
and removed
Priority 2
These are normal bugs that don't break site functionality, but don't necessarily work well.
labels
Sep 10, 2018
No. This is about running the eligibility check when requesting to signup rather than to see if we should put the signup button there or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, the check is only done for showing or not showing the button, but doesn't stop someone from just sending a direct request to the API to bypass the button to sign up for any position regardless of eligibility.
The text was updated successfully, but these errors were encountered: