Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly check eligibility when someone signs up for a crew #59

Open
MasterOdin opened this issue Sep 10, 2018 · 2 comments
Open

Properly check eligibility when someone signs up for a crew #59

MasterOdin opened this issue Sep 10, 2018 · 2 comments
Labels
BUG Priority 1 This is something we want fixed first and foremost. Security

Comments

@MasterOdin
Copy link
Member

Right now, the check is only done for showing or not showing the button, but doesn't stop someone from just sending a direct request to the API to bypass the button to sign up for any position regardless of eligibility.
@MasterOdin MasterOdin added BUG Priority 2 These are normal bugs that don't break site functionality, but don't necessarily work well. labels Sep 10, 2018
@MasterOdin MasterOdin mentioned this issue Sep 10, 2018
Closed
@MasterOdin MasterOdin changed the title Probably check eligibility when someone signs up for a crew Properly check eligibility when someone signs up for a crew Sep 10, 2018
@lramos15 lramos15 added Priority 1 This is something we want fixed first and foremost. and removed Priority 2 These are normal bugs that don't break site functionality, but don't necessarily work well. labels Sep 10, 2018
@ddbruce
Copy link
Member

ddbruce commented Jan 27, 2020

@lramos15 was this fixed in #104?

@lramos15
Copy link
Member

No. This is about running the eligibility check when requesting to signup rather than to see if we should put the signup button there or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Priority 1 This is something we want fixed first and foremost. Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MasterOdin @lramos15 @ddbruce