-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vCard: Use sabre/vobject library #9641
Comments
I started doing things: https://github.com/respiranto/roundcubemail/commits/devel-vcard-sabre-vobject |
Question 1: How should / can I report errors on parsing?
For (b), I'd like to cause a user-visible message like "Failed importing $person_name", "Failed importing record without name or e-mail address ($record_data)", "Failed importing vCard due to unsupported encoding". |
Question 2 (backslash handling): Would it be OK to break #4189 (and
|
Question 3 (charset support): Would it be OK to reduce the set of supported charsets to that supported by sabre/vobject?
|
Suggestion 4 (charset support): Restrict document charset to (and assume) UTF-8.
|
|
|
Testing:
GMail example:
Thunderbird example:
|
Note that I have found 15 issues (mostly bugs) for sabre/vobject so far, all of which we should be able to work with, some of which may require workarounds. |
@respiranto Wow, I'm impressed! Thank you very much already! (I'm currently mostly distracted by other topics, unfortunately, so for me it might take a while to react to questions.) |
The vCard code currently has its own custom vCard parser. There are many issues with the current code and I deemed it better to use an external library, sabre/vobject being the apparently best choice.
See in particular the bug report #9593.
This may also help to address #9590.
The text was updated successfully, but these errors were encountered: