Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license in package.xml or file headers #28

Open
shr-project opened this issue Aug 14, 2019 · 1 comment
Open

Fix license in package.xml or file headers #28

shr-project opened this issue Aug 14, 2019 · 1 comment

Comments

@shr-project
Copy link

Can you please fix the license version in package.xml?

Currently
https://github.com/ros-perception/slam_karto/blob/melodic-devel/package.xml#L12
says only LGPL, while:
https://github.com/ros-perception/slam_karto/blob/melodic-devel/src/slam_karto.cpp#L5
says CCPL (looks like some CC-BY-* variant)
https://github.com/ros-perception/slam_karto/blob/melodic-devel/src/spa_solver.cpp#L5
says LGPL-3+

superflore maps this to LGPL-2 in:
https://github.com/ros-infrastructure/superflore/blob/master/superflore/utils.py#L179
and LGPL-2 isn't valid SPDX Identifier in:
https://spdx.org/licenses/
so it would be better to declare the license correctly at the source - in package.xml.

@mikeferguson
Copy link
Member

I'm actually not exactly sure what "single" license we could put there. This package pulls the SPA solver code from the Karto release (so the LGPL-3+ is correct there), and it pulls the slam_karto.cpp from the slam_gmapping code, which had that license because gmapping WAS CC - but has now been rereleased as BSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants