From e71c3598c90fd4e18e64c8320dc63feef50ad4e8 Mon Sep 17 00:00:00 2001 From: Parker Drouillard Date: Fri, 12 Jul 2024 01:17:16 -0400 Subject: [PATCH 1/3] Update test_resource_manager.cpp - Fixed Typo Fixed typo causing errors during build, test case was written as initilizable and not initializable as was expected by the tests. --- hardware_interface_testing/test/test_resource_manager.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hardware_interface_testing/test/test_resource_manager.cpp b/hardware_interface_testing/test/test_resource_manager.cpp index 5fb155fa3a..192e931229 100644 --- a/hardware_interface_testing/test/test_resource_manager.cpp +++ b/hardware_interface_testing/test/test_resource_manager.cpp @@ -137,9 +137,9 @@ void test_load_and_initialized_components_failure(const std::string & urdf) EXPECT_FALSE(rm.command_interface_exists("joint3/max_acceleration")); } -TEST_F(ResourceManagerTest, test_unitilizable_hardware) +TEST_F(ResourceManagerTest, test_unitializable_hardware) { - SCOPED_TRACE("test_unitilizable_hardware_no_validation"); + SCOPED_TRACE("test_unitializable_hardware_no_validation"); // If the the hardware can not be initialized and load_and_initialize_components didn't try to // validate the interfaces, the interface should not show up test_load_and_initialized_components_failure( From bf04cf86273367bc2fe40a1fd6f2ef82f721389c Mon Sep 17 00:00:00 2001 From: Parker Drouillard Date: Fri, 12 Jul 2024 03:29:57 -0400 Subject: [PATCH 2/3] Update test_resource_manager.cpp - additional typo correction Fixed ininitializable to uninitializable (Even for a native English speaker that's a rough one) --- hardware_interface_testing/test/test_resource_manager.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hardware_interface_testing/test/test_resource_manager.cpp b/hardware_interface_testing/test/test_resource_manager.cpp index 192e931229..13cec91b76 100644 --- a/hardware_interface_testing/test/test_resource_manager.cpp +++ b/hardware_interface_testing/test/test_resource_manager.cpp @@ -137,16 +137,16 @@ void test_load_and_initialized_components_failure(const std::string & urdf) EXPECT_FALSE(rm.command_interface_exists("joint3/max_acceleration")); } -TEST_F(ResourceManagerTest, test_unitializable_hardware) +TEST_F(ResourceManagerTest, test_uninitializable_hardware) { - SCOPED_TRACE("test_unitializable_hardware_no_validation"); + SCOPED_TRACE("test_uninitializable_hardware_no_validation"); // If the the hardware can not be initialized and load_and_initialize_components didn't try to // validate the interfaces, the interface should not show up test_load_and_initialized_components_failure( ros2_control_test_assets::minimal_uninitializable_robot_urdf); } -TEST_F(ResourceManagerTest, initialization_with_urdf_and_manual_validation) +TEST_F(ResourceManagerTest, uninitialization_with_urdf_and_manual_validation) { // we validate the results manually TestableResourceManager rm(node_, ros2_control_test_assets::minimal_robot_urdf, false); From 98f807b036e3d2dd3e5f9d06b5227655070e762f Mon Sep 17 00:00:00 2001 From: Parker Drouillard Date: Fri, 12 Jul 2024 03:54:30 -0400 Subject: [PATCH 3/3] Update hardware_interface_testing/test/test_resource_manager.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Christoph Fröhlich --- hardware_interface_testing/test/test_resource_manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hardware_interface_testing/test/test_resource_manager.cpp b/hardware_interface_testing/test/test_resource_manager.cpp index 13cec91b76..51d81a90ab 100644 --- a/hardware_interface_testing/test/test_resource_manager.cpp +++ b/hardware_interface_testing/test/test_resource_manager.cpp @@ -146,7 +146,7 @@ TEST_F(ResourceManagerTest, test_uninitializable_hardware) ros2_control_test_assets::minimal_uninitializable_robot_urdf); } -TEST_F(ResourceManagerTest, uninitialization_with_urdf_and_manual_validation) +TEST_F(ResourceManagerTest, initialization_with_urdf_and_manual_validation) { // we validate the results manually TestableResourceManager rm(node_, ros2_control_test_assets::minimal_robot_urdf, false);