Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using sub docs makes the edit button less helpful #30

Open
steffilazerte opened this issue Aug 25, 2020 · 4 comments
Open

Using sub docs makes the edit button less helpful #30

steffilazerte opened this issue Aug 25, 2020 · 4 comments

Comments

@steffilazerte
Copy link
Collaborator

Right now the edit button works, but links to https://github.com/ropensci-org/contributing-guidance/edit/master/intro.Rmd because we use sub docs. This isn't super helpful...

@stefaniebutland
Copy link
Contributor

Can this also be the reason hitting "back" in my browser does not go back where I was?

@stefaniebutland stefaniebutland added this to the Nice to have one day milestone Jan 14, 2021
@steffilazerte
Copy link
Collaborator Author

The back button works fine for me (firefox), but I don't think we can fix the "Edit this page" link unless we combine all subsections into one document (rstudio/bookdown#315) which I'd rather not do for editorial reasons!

@maelle
Copy link
Collaborator

maelle commented Jul 27, 2022

why not make the current chapters "parts" and the current sections "chapters"? Do you really want them to be a single page in the HTML output @steffilazerte?

@steffilazerte
Copy link
Collaborator Author

I think that makes sense...? Some pages, like the Introduction and Code of Conduct in Chapter 3, would be really small pages, is that okay? This would also result in different hard links. I think that's okay to change them?

@yabellini and I have a chat this afternoon and the Contributing Guide is on the agenda, so will discuss more then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants