Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Make "Add Illini Cash" feature available for not logged in users. #4342

Open
mihail-varbanov opened this issue Sep 11, 2024 · 2 comments
Labels
Type: Feature Request Requesting a new feature

Comments

@mihail-varbanov
Copy link
Collaborator

mihail-varbanov commented Sep 11, 2024

A long time ago, before we introduced the above panel that embeds all Wallet functionality, we updated the visibility of different commands or widgets depending on user role, login status, etc. I do remember that there were absolutely no restrictions for the "Add Illini Cash" command because it was supposed to be used by parents, for example, that do not have Illini ID/account.

Now we combine everything in a single panel and require online status and OIDC login in order to display its content. This effectively disables "Add Illini Cash" but should not. I think we should find some different way to handle offline or not logged in cases when in this panel.

And since this is not the only panel that makes such preliminary checks before presentation, we should also check all similar panels, e.g. Notifications, GIES/New Student CheckList, etc.

Sourve: https://rokwire-workspace.slack.com/archives/CEXARQXQR/p1725369426553559?thread_ts=1725293154.195409&cid=CEXARQXQR

Screenshot 2024-09-02 at 7 04 12 PM

@mihail-varbanov
Copy link
Collaborator Author

Hi @vburgett,

I made an update that makes the "Add Illini Cash" feature available for the users that are not logged in. In this case we allow loading the Wallet panel with "Add Illini Cash" selected content, but do not allow switching to the other Wallet features (e.g. Illini ID, Illini Cash, etc.). This is available in version 6.0.42.

@pmarkhennessy and I discussed some better UX resolutions for long run (6.1++), he will reach you for this.

@vburgett
Copy link

vburgett commented Sep 13, 2024

I was able to successfully add Illini cash without being signing in with a NetID in 6.0.43 on dev. Thank you! (cc: @kpecknold)

@vburgett vburgett removed their assignment Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

2 participants