-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install plugin from CLI #200
Comments
The original approach I took was to use a Cargo feature to Hurting the |
@LPGhatguy Build scripts could package an rbxmx (and in the future, rbxm) automatically, is that a reasonable approach? |
A build script would need a copy of Rojo to bundle in. They run when you |
If |
I don't think we're dropping |
Actually, I don't believe crates on Cargo have to be exclusively Rust code. All they really need is a |
Cargo rejects things that aren't checked into source control by default when you @jeparlefrancais had a good idea, which is to include the plugin source in some sort of tarball-y thing, like by generating some bincode in We could take this idea a step further and split apart Rojo's library and binary parts more. Then we can consume the library part from Rojo's |
Does the new reconciler make this easier? |
Rojo should be able to install the plugin from the CLI. This would make #169 easier since there wouldn't need to be any special procedure for installing the built in plugin side (maybe even the whole plugin can be built in?).
The weird part is how to actually accomplish this. There's many possibilities but none are that great. The ideas I can think of off the top of my head are:
Downloading from online. This is the easiest to do but has complications with versions and local development.
Bundling the plugin somehow, like with
include_str!
or some build script mumbo jumbo. This has issued withcargo install
, but maybe Rojo should release its own binaries anyway, asking people to install Rust to use Rojo is a bit clunky. The docs denounce other syncing tools for having to have the user install their language's environment: "I think that this tool needs to be built in a compiled language without a runtime, for easy distribution and good performance.".The text was updated successfully, but these errors were encountered: