Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make error? #80

Open
develperbayman opened this issue Jan 18, 2023 · 3 comments
Open

make error? #80

develperbayman opened this issue Jan 18, 2023 · 3 comments

Comments

@develperbayman
Copy link

make[1]: Entering directory '/home/developerbayman/rkdeveloptool'
g++ -DHAVE_CONFIG_H -I. -I./cfg -Wall -Werror -Wextra -Wreturn-type -fno-strict-aliasing -D_FILE_OFFSET_BITS=64 -D_LARGE_FILE -I/usr/include/libusb-1.0 -g -O2 -MT main.o -MD -MP -MF .deps/main.Tpo -c -o main.o main.cpp
main.cpp: In function ‘bool _Z9mergeBootv.part.0()’:
main.cpp:1493:43: error: ‘%s’ directive output may be truncated writing up to 557 bytes into a region of size 5 [-Werror=format-truncation=]
1493 | snprintf(buffer, sizeof(buffer), "%s", chip);
| ^~
......
1534 | chipType = convertChipType(chip + 2);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/stdio.h:894,
from DefineHeader.h:3,
from main.cpp:11:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:71:35: note: ‘__builtin_snprintf’ output between 1 and 558 bytes into a destination of size 5
71 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
72 | __glibc_objsize (__s), __fmt,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
73 | __va_arg_pack ());
| ~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[1]: *** [Makefile:491: main.o] Error 1
make[1]: Leaving directory '/home/developerbayman/rkdeveloptool'
make: *** [Makefile:511: install-recursive] Error 1

@VilleWitt
Copy link

VilleWitt commented Jan 22, 2023

Temporary, one could add ignore the format-truncation error from GCC:

snprintf(buffer, sizeof(buffer), "%s", chip);

into

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wformat-truncation"
    snprintf(buffer, sizeof(buffer), "%s", chip);
#pragma GCC diagnostic pop

In main.cpp:covertChipType(...)

@mainmachine
Copy link

Looks like this might be an actual fix:

#70

@KSNWH
Copy link

KSNWH commented Mar 23, 2023

Hi,
as buffer is 5 characters you can just change the line 1493 to:
snprintf(buffer, sizeof(buffer), ".4%s", chip);
(according to https://cplusplus.com/reference/cstdio/printf/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants