Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce heap usage and allocations #210

Closed
AbstractiveNord opened this issue Mar 17, 2024 · 2 comments
Closed

Reduce heap usage and allocations #210

AbstractiveNord opened this issue Mar 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@AbstractiveNord
Copy link

Let's use more smart string types, such as FastStr provided via fast_str crate.
@RAnders00 RAnders00 changed the title Reduce heap usage with fast_str crate Reduce heap usage and allocations Mar 18, 2024
@RAnders00 RAnders00 added the enhancement New feature or request label Mar 18, 2024
@Nerixyz
Copy link
Contributor

Nerixyz commented Mar 18, 2024

Seems like a duplicate of #178. As for the type, I think in many cases a &str pointing into the raw message can be fine as long as there aren't any escape characters.

@RAnders00
Copy link
Collaborator

Thanks @Nerixyz, I had felt like there was a ticket for that before but must have overlooked it.

@RAnders00 RAnders00 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RAnders00 @Nerixyz @AbstractiveNord