-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider moving omit extra data functionality to schemaUtils #4081
Labels
Comments
MarekBodingerBA
added
needs triage
Initial label given, to be assigned correct labels and assigned
question
labels
Feb 5, 2024
MarekBodingerBA
changed the title
Consider adding omit extra data functionality to schemaUtils
Consider moving omit extra data functionality to schemaUtils
Feb 5, 2024
@MarekBodingerBA We would love to get help on this! Feel free to push up a PR for us to review. |
heath-freenome
added
help wanted
feature
Is a feature request
and removed
needs triage
Initial label given, to be assigned correct labels and assigned
labels
Feb 16, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
What theme are you using?
core
What is your question?
Hello,
Due to the advanced way in which we use RJSF, we need to programmatically omit extra data. We have implemented our own step functionality on top of RJSF, and we need to filter out extra data without submitting the form when switching between steps, as
liveOmit
is hitting our performance requirements.Temporarily, we have created a custom function that mimics the logic from here and here:
Using new Form in this manner is entirely possible, as neither
getFieldNames
norgetUsedFormData
accessthis
. However, it is clear that this is not the best long-term solution. The extraction could be beneficial for other users and would help to avoid duplicating the same logic if it were centralized. WouldschemaUtils
be an appropriate place for this? A similar function,getDefaultFormState
, already exists there.I propose the following:
schemaUtils.omitExtraData
and replace its usage in theForm
.I can work on this if you give me the green light to proceed.
Thanks!
The text was updated successfully, but these errors were encountered: