Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for 588 #1616

Open
jenniferward opened this issue Jul 15, 2024 · 1 comment
Open

Validation for 588 #1616

jenniferward opened this issue Jul 15, 2024 · 1 comment
Assignees
Milestone

Comments

@jenniferward
Copy link
Contributor

In the templates for printed music, the field 588 is open and yellow. Catalogers in a hurry sometimes start putting notes there (example: https://muscat-test.rism.info/admin/sources/1001131300), and then forget a proper 588 because the validation see text in 588. Or they just enter their shelfmark, which can become hard to interpret if eventually many more holdings are added. The proper form in 588 is siglum and shelfmark.

Can there be a validation for 588? At the very least there should be a - to signal a siglum. That might be enough to make catalogers look again.

xhero added a commit that referenced this issue Oct 16, 2024
@jenniferward jenniferward added this to the 11.2 milestone Oct 23, 2024
@xhero
Copy link
Contributor

xhero commented Oct 23, 2024

For the moment it just checks for "-", in the next release we could make it more clever

@xhero xhero self-assigned this Oct 28, 2024
@xhero xhero modified the milestones: 11.2, 11.3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants