Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply new package structure to test packages #83

Open
10 tasks
madmas opened this issue Apr 17, 2020 · 0 comments
Open
10 tasks

apply new package structure to test packages #83

madmas opened this issue Apr 17, 2020 · 0 comments
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@madmas
Copy link
Member

madmas commented Apr 17, 2020

🆕🐥 First Timers Only

This issue is reserved for people who never contributed to Rico or Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

👾 Description of the issue

The new package structure introduces with #79 was not applied to the contents of test/ in all modules. These should be aligned. Therefore all test packages that are not aligned to the packages under main/ should be refactored. The following image gives an example of the rico-remoting-server module that provides the dev.rico.remoting.server as package under main/ but dev.rico.server.remoting as package under test/.

packages

📋 Step by Step

To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

  • Claim this issue: Comment below.
  • Fork the repository in github by simply clicking the 'fork' button.
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have any naming definition for branches, but it doesn't hurt if it contains the issue number ;-)
  • Commit your changes.
  • Start a Pull Request.
  • Done 👍 Ask in comments for a review :)
  • If the reviewer finds some missing pieces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
  • You did it 🎉 We will merge the fix in the master branch.
  • Thanks, thanks, thanks for being part of this project as an open source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. 🎽

🤔❓ Questions

If you have any questions just ask us directly in this issue by adding a comment. Next to this you can find a general manual about open source contributions here.

@hendrikebbers hendrikebbers added good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed help wanted Extra attention is needed labels Oct 1, 2020
@madmas madmas added good first issue Good for newcomers Hacktoberfest and removed good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed labels Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants