Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag_namespaces generates page filenames like _site/software/writtenin:Ruby/index.html which fails in GHA artefact upload #83

Open
ronaldtse opened this issue Mar 20, 2022 · 3 comments
Assignees
Labels
bug Something isn't working ⚙️ operations

Comments

@ronaldtse
Copy link
Contributor

GHA artifact upload fails at filenames like _site/software/writtenin:Ruby/index.html because the : symbol is not supported, due to NTFS restrictions.

Based on best practice, we should not use filenames with colons.

This issue is described here:
actions/upload-artifact#35 (comment)

The failing action is located here:
https://github.com/metanorma/metanorma.org/runs/5616204145?check_suite_focus=true

@ronaldtse ronaldtse added the bug Something isn't working label Mar 20, 2022
@strogonoff
Copy link
Contributor

strogonoff commented Mar 20, 2022

We use these links, and they work: https://open.ribose.com/software/writtenin:Ruby/

Other sites use them as well: http://en.wikipedia.org/wiki/Template:Welcome

I’m not sure we should change URLs due to artifact-upload behavior and NTFS limitations. Could we avoid uploading intermediate artifacts and just upload the result straight to AWS? It seems that it works (or has worked previously), so is artifact upload not really necessary? If there is a sound reason, perhaps we could just zip the directory and bypass this issue.

@strogonoff strogonoff added ⚙️ operations bug Something isn't working and removed bug Something isn't working labels Mar 20, 2022
@strogonoff
Copy link
Contributor

strogonoff commented Mar 20, 2022

I will see if this can be worked around with percent-escaped characters in file paths (in the helpers gem), but only if it’s low-effort and straightforward to do with Jekyll.

I re-added the “bug” label back since we do not state that Open Project theme does not support NTFS, so if the above fails at the very least docs would be updated.

@ronaldtse
Copy link
Contributor Author

I've temporarily worked around this by pre-zipping the file before GHA artifact upload and manually unzipping it after: metanorma/metanorma.org@0d623b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ⚙️ operations
Projects
None yet
Development

No branches or pull requests

2 participants