Class methods should return objects with expected classes

[ronaldtse]

Hi @abunashir ,

When I was testing out the code I noticed that some responses do not return properly 'classed' objects.

For example,

Digicert::Product.all.first.class
=> Digicert::ResponseObject

But the expectation of someone running this should be Digicert::Product.

Could you help go through the code and see which calls are returning the generic ResponseObject and give them the proper classes?

Thanks!

[abunashir]

Hi @ronaldtse, we are parsing any response to ResponseObject, which is basically parsing the json response to deeply nested OpenStruct object( click here to see the source). Like we spoke before, because of the inconsistent nature of the Digicert response and to make it more flexible we used it.

We can change it to return an Actual class but then we have to specify every attribute in each of our classes, we can try to do that now but I feel like that might be lot of headache to mange whenever there is a change in Digicert response. Personally, I feel that the path we will take once this client is little bit stable. Please let me know your thoughts

[ronaldtse]

@abunashir that's fine. We should probably implement Digicert::Order.all to allow calls like:

certificate = Digicert::Order.all.first.certificate
duplicated_certificate = Digicert::Order.all.first.duplicates.certificate

[ronaldtse]

@abunashir the client seems stable enough to move forward with this. What do you think?

[abunashir]

@ronaldtse: Yap, that's on the top of the list right now. We are in a pretty much stable situation and I am hoping to move away from OpenStruct response type and include this one in the v1.0.