Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly renames blocks if file paths are non-standard #5

Open
lmontgomery-lyonscg opened this issue Oct 28, 2015 · 1 comment
Open

Comments

@lmontgomery-lyonscg
Copy link

I had this happen when one of the projects I work on had the Webshopapps_Wsalogger module installed. It has a path Webshopapps/Wsalogger/Adminhtml/Block which appears to confuse the script in the _moveAdminControllers function.

For example it renamed Webshopapps_Wsalogger_Adminhtml_Block_Log_Grid_Renderer_Actions to Webshopapps_Wsalogger_Adminhtml_Wsalogger_Block_Log_Grid_Renderer_Actions.

The module in question is on Github as well: https://github.com/webshopapps/wsalogger

@rhoerr
Copy link
Owner

rhoerr commented Oct 28, 2015

Yes, I've seen that as well. It happens because that module breaks convention on its blocks: Webshopapps/Wsalogger/Adminhtml/Block/... rather than Webshopapps/Wsalogger/Block/Adminhtml/... .

Not much to do about that short of whitelisting those block files before running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants