Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Generate Whitelist Data Install Script #3

Open
mpchadwick opened this issue Oct 28, 2015 · 3 comments
Open

Auto Generate Whitelist Data Install Script #3

mpchadwick opened this issue Oct 28, 2015 · 3 comments

Comments

@mpchadwick
Copy link
Contributor

Rather than just doing this

$this->_write->insertMultiple( $this->_blocksTable, array_values( $inserts ) );
it might be nice if this created a data install script for the necessary blocks and variables (perhaps optionally). That way you can deploy the upgrade script rather than running this in production. Magento "technical details" also recommend a data install script. I'm sure everyone is busy getting this patch out, but if anyone has time (I can maybe, but probably not PR this myself).

@rhoerr
Copy link
Owner

rhoerr commented Oct 28, 2015

The tech details recommendation was in regards to affected modules, and in that context it does make sense. Creating a module, you'd want to make sure any blocks needed are added to the whitelist when it gets installed.

To do that, though, you need a module to attach the data upgrade to. Don't have that in this context. You could generate everything needed, for sure, but that's getting rather involved.

@mpchadwick
Copy link
Contributor Author

Yeah, it certainly wouldn't be trivial, but would be nice...even just to get the install script only would save some time and then it would be on the developer to create the module to make sure it gets executed...

@chelevich
Copy link

created a PR to get the upgrade scripts from log file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants