Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions about Structure_Att and Detail_Att #3

Open
yogsin opened this issue Jun 25, 2019 · 1 comment
Open

questions about Structure_Att and Detail_Att #3

yogsin opened this issue Jun 25, 2019 · 1 comment

Comments

@yogsin
Copy link

yogsin commented Jun 25, 2019

Hi, thanks for your job!
There are two points in the code I cannot understand:
1.line 133 in tasn-mxnet/example/tasn/model.py: mx.nd.batch_dot(b.reshape((n,c,1)), f.reshape((n,c,w*w)), True, False).reshape((n,1,w,w))
b is sorted but f not, i don't think their attention channels can match one by one.

2.the channels in both Structure_Att and Detail_Att are filtered to make sure that each channel is unique,but why you think the channels with the same sum value can be represented by one of these channels?

looking forward to your reply.

@Heliang-Zheng
Copy link
Member

@yogsin Sorry for my late reply, and thanks for your valuable comments.

  1. I think you are right, and I will fix this bug.
  2. I thought it is a rare case for two different attention maps share the same sum value, and of course, you can try a more strict unique selecting strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants