Replacement doesn't work as expected

[djsjo]

Problem

I have some lines with times like:
11:30
11:45
12:00
12:15

and wanted to replace them with the same value + a colon and a space.

Used Command

:%s/\v(\d{2}:\d{2})/\1: /gc

Expected Results:

The accordings lines are replaced with the colon counterpart. Tested in "real" vim and it works.

Actual Results

Tested in codemirror.net
Getting the Information "No matches for \v(\d{2}:\d{2})" .

[nightwing]

We do not support \v modifier.
By default we use js compatible regexps so %s/(\d{2}:\d{2})/$1: /gc should work

Also it is possible to do :set nopcre :%s/\(\d{2}:\d{2}\)/\1: /gc

We need to implement better error messages/hints to show which mode of regular expressions is activated.

Do you think it would be useful to support \v in nopcre mode?

[nightwing]

@djsjo the attached pull request improves support for vim style regular expressions and informs user that regex mode can be changed. Could you try it on https://raw.githack.com/replit/codemirror-vim/verymagic/dev/web-demo.html and let us know if there are any issues. Thanks!

[djsjo]

I will check it out in the middle of next week and report to you. Thanks

[djsjo]

@nightwing everything works as anticipated and the feedback is very helpful. But when I set ":set nopcre" and then
":%s/(\d{2}:\d{2})/\1: /gc" it showed me "No matches for /(\d{2}:\d{2})/im"
I guess thats not the correct behaviour right?
The \v mode in nopcre mode worked fine :)

[nightwing]

In your example you did not escape the brace in {2}, and for me, the default configuration of vim, does not find matches for it either. \{2} works.
Does vim find matches without escaping the brace with your configuration?

Also how should + work, our old implementation does not require to escape it, but vim seems to require.